GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94801: Use custom flags to check for headers and libs by tiran · Pull Request #94802 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 13, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran added the needs backport to 3.11 only security fixes label Jul 13, 2022
@tiran
tiran requested a review from erlend-aasland July 13, 2022 08:14
@bedevere-bot bedevere-bot added the awaiting core review label Jul 13, 2022
@tiran

tiran commented Jul 13, 2022

Copy link
Copy Markdown
Member Author

I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran marked this pull request as ready for review July 13, 2022 21:30
@tiran
pythongh-94801: Use custom flags to check for headers and libs
7bb04f3
@tiran
tiran force-pushed the gh-94801-cflags branch from 6e49f8e to 7bb04f3 Compare July 14, 2022 08:08
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
@bedevere-bot

bedevere-bot commented Jul 14, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 7bb04f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 14, 2022
erlend-aasland
erlend-aasland approved these changes Jul 14, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 14, 2022
@tiran
use CPPFLAGS, add PY_CHECK_EMSCRIPTEN_PORT macro
1311551
@tiran tiran added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 15, 2022
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 15, 2022
erlend-aasland
erlend-aasland approved these changes Jul 15, 2022
View reviewed changes
@tiran tiran added the 🤖 automerge label Jul 15, 2022
@tiran
tiran merged commit 944ff8c into python:main Jul 15, 2022
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 15, 2022
@tiran
tiran deleted the gh-94801-cflags branch July 15, 2022 12:48
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 944ff8c57c9e8ff5a5bd18925070ddb1504490ab 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Jul 15, 2022
tiran added a commit to tiran/cpython that referenced this pull request Jul 15, 2022
@tiran
[3.11] pythongh-94801: Use custom flags to check for headers and libs (…
96e6bec 
…pythonGH-94802).

(cherry picked from commit 944ff8c)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

GH-94881 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran added a commit that referenced this pull request Jul 18, 2022
@tiran
[3.11] gh-94801: Use custom flags to check for headers and libs (GH-9…
30412d9 
…4802) (GH-94881)

Co-authored-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this pull request Jul 18, 2022
gh-90005: Port readline and curses to PY_STDLIB_MOD (GH-94452) #94452
Merged
@zanieb zanieb mentioned this pull request Dec 30, 2024
gh-128354: Use LIBS consistently over LDFLAGS in library build checks #128359
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @miss-islington @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.