GeezerVison

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit f530250 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Thanks for the work, Would you like to provide a reproducible way for detecting leaks?

Thanks for the work, Would you like to provide a reproducible way for detecting leaks?

The following script causes negative ref count:

for i in range(1000):
    a = repr(False)

Output:

@kumaraditya303 ➜ /workspaces/cpython (main ✗) $ ./python -X showrefcount main.py 
[-1001 refs, 0 blocks]

@corona10: The following script causes negative refcount with TextIOWrapper:

# main.py
from io import TextIOWrapper

a = TextIOWrapper(open('main.py','rb'))
for i in a:
    pass
a.close()

Output:

@kumaraditya303 ➜ /workspaces/cpython (main ✗) $ ./python -X showrefcount main.py 
[-2 refs, 0 blocks]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Looking, I wonder why only two bots failed if there are refleaks.

It is also leaking at my local environment :(

Yeah, I am also able to reproduce, bisecting which one is causing leak

I am getting refleak on main branch too, test.test_io.CTextIOWrapperTest.test_reconfigure_locale is failing.

Refleak was fixed by #94858

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0a76abd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Refleak buildbots are failing on main too, see #94979

Thanks @kumaraditya303 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

GH-95037 is a backport of this pull request to the 3.11 branch.

Thanks for the review @corona10!