GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81040: Improve sqlite3.Cursor.rowcount docs by erlend-aasland · Pull Request #94940 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Resolves gh-81040

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-81040: Improve sqlite3.Cursor.rowcount docs
1950829
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 17, 2022 22:19
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 17, 2022
@erlend-aasland
erlend-aasland requested review from AlexWaygood and CAM-Gerlach July 17, 2022 22:19
@erlend-aasland erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jul 17, 2022
erlend-aasland
erlend-aasland commented Jul 17, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach reviewed Jul 22, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggested tweaks, otherwise LGTM, thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address CAM's review
cdd0bcd
@erlend-aasland

erlend-aasland commented Jul 22, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review, CAM!
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit f9b3706 into python:main Jul 22, 2022
@miss-islington

miss-islington commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 22, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-doc-rowcount branch July 22, 2022 07:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
@erlend-aasland @miss-islington
pythongh-81040: Improve sqlite3.Cursor.rowcount docs (pythonGH-94940)
bca4b3d 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2022
@bedevere-bot

bedevere-bot commented Jul 22, 2022

Copy link
Copy Markdown

GH-95124 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2022
@erlend-aasland @miss-islington
pythongh-81040: Improve sqlite3.Cursor.rowcount docs (pythonGH-94940)
7bcc42a 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jul 22, 2022
@bedevere-bot

bedevere-bot commented Jul 22, 2022

Copy link
Copy Markdown

GH-95125 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jul 22, 2022
sqlite3 dml statement detection does not account for CTEs #81040
Closed
miss-islington added a commit that referenced this pull request Jul 22, 2022
@miss-islington @erlend-aasland
gh-81040: Improve sqlite3.Cursor.rowcount docs (GH-94940)
02f1cac 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jul 22, 2022
@miss-islington @erlend-aasland
gh-81040: Improve sqlite3.Cursor.rowcount docs (GH-94940)
12b56e4 
(cherry picked from commit f9b3706)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
@AlexWaygood
AlexWaygood removed their request for review July 28, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3 dml statement detection does not account for CTEs

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.