GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-94816: Improve coverage of decode_linetable" by mdboom · Pull Request #94982 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Jul 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As discussed in the backport to 3.11, this test is perhaps a little too brittle, as it will change any time the bytecode generation changes. We still should improve the coverage of co_lnotab, but we should go back to the drawing board to find a way that tests what's needed without being so sensitive to change.

Reverts #94853

Cc: @brandtbucher

  • Issue: [coverage] codeobject.c: decode_linetable #94816

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mdboom
Revert "pythongh-94816: Improve coverage of decode_linetable (pythonG…
f9e135e
…H-94853)"

This reverts commit 20b9d2a.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 18, 2022
@mdboom mdboom mentioned this pull request Jul 18, 2022
[3.11] gh-94816: Improve coverage of decode_linetable (GH-94853) #94884
Closed
@brandtbucher brandtbucher added the skip news label Jul 18, 2022
@brandtbucher
brandtbucher merged commit 4b5360c into python:main Jul 18, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mdboom @bedevere-bot @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.