GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94816: Improve coverage of decode_linetable by mdboom · Pull Request #94853 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Jul 14, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.

  • Issue: [coverage] codeobject.c: decode_linetable #94816

Automerge-Triggered-By: GH:brandtbucher

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 14, 2022
@AlexWaygood AlexWaygood added the skip news label Jul 14, 2022
mdboom added 2 commits July 14, 2022 11:36
@mdboom
pythongh-94816: Improve coverage of decode_linetable
751bacf 
This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.
@mdboom
Make work without default encoding
5e8ec42
@mdboom
mdboom force-pushed the codeobject-getlnotab-coverage branch from 0d9d83d to 5e8ec42 Compare July 14, 2022 15:43
brandtbucher
brandtbucher reviewed Jul 14, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few notes:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mdboom
Use list rather than repr. Use blank lines rather than docstring.
7857e50
@mdboom
mdboom requested a review from brandtbucher July 14, 2022 19:17
brandtbucher
brandtbucher approved these changes Jul 14, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion (not a big deal, though). Just let me know when you're happy with it and I'll merge.

I'm guessing we won't be backporting any of these?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 14, 2022
@mdboom @brandtbucher
Update Lib/test/test_code.py
c77f49d 
Co-authored-by: Brandt Bucher <[email protected]>
@mdboom
mdboom force-pushed the codeobject-getlnotab-coverage branch from e4e54f2 to c77f49d Compare July 14, 2022 19:46
@mdboom

mdboom commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

One tiny suggestion (not a big deal, though). Just let me know when you're happy with it and I'll merge.

Good suggestion. I made one tweak (the first opcode is a 2, not a 0). I'm fine with this now.

I'm guessing we won't be backporting any of these?

IMHO, I think it would be good to backport these to 3.11, but I defer to those with more experience with the process. I don't have perms to add the backport label ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom

mdboom commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

Windows x86 failure seems unrelated?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Jul 14, 2022

Copy link
Copy Markdown
Member

Windows x86 failure seems unrelated?

Rerunning it now. I'll merge on success, then we can discuss on #94808 whether these should be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher brandtbucher added the 🤖 automerge label Jul 14, 2022
@miss-islington

miss-islington commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 20b9d2a into python:main Jul 14, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 14, 2022
@brandtbucher brandtbucher added the needs backport to 3.11 only security fixes label Jul 15, 2022
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Sorry @mdboom, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 20b9d2a658059c8c1624400f60bb6ba19a31ee9b 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington self-assigned this Jul 15, 2022
@brandtbucher brandtbucher added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 15, 2022
@miss-islington

miss-islington commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2022
@mdboom @miss-islington
pythongh-94816: Improve coverage of decode_linetable (pythonGH-94853)
f8d5018 
This makes calls to co_lnotab to exercise this code, as well
as generating synthetically large code to exercise the corner
cases where line numbers need multiple bytes.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit 20b9d2a)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
@bedevere-bot

bedevere-bot commented Jul 15, 2022

Copy link
Copy Markdown

GH-94884 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mdboom added a commit to mdboom/cpython that referenced this pull request Jul 18, 2022
@mdboom
Revert "pythongh-94816: Improve coverage of decode_linetable (pythonG…
f9e135e 
…H-94853)"

This reverts commit 20b9d2a.
@mdboom mdboom mentioned this pull request Jul 18, 2022
Revert "gh-94816: Improve coverage of decode_linetable" #94982
Merged
brandtbucher pushed a commit that referenced this pull request Jul 18, 2022
@mdboom
Revert "gh-94816: Improve coverage of decode_linetable (GH-94853)" (G…
4b5360c 
…H-94982)

This reverts commit 20b9d2a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mdboom @brandtbucher @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.