GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… by graingert · Pull Request #95009 · python/cpython

Conversation

graingert commented Jul 19, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched

Issue: test_asyncio's GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher is not run #95010

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added tests

Tests in the Lib/test dir

awaiting review labels

Jul 19, 2022

graingert changed the title ~~fix GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…~~ fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…

Jul 19, 2022

graingert force-pushed the fix-generic-watcher-tests branch from 823b0c4 to 9877b92 Compare

July 19, 2022 15:32

graingert changed the title ~~fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…~~ gh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…

Jul 19, 2022

graingert commented Jul 19, 2022

Copy link

Copy Markdown

Contributor Author

this is just a test change and doesn't need news

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

graingert changed the title ~~gh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…~~ gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…

Jul 19, 2022


          pythongh-95010: fix asyncio GenericWatcherTests.test_create_subproces…

20b9bd0

…s_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched

graingert force-pushed the fix-generic-watcher-tests branch from 4f47e21 to 20b9bd0 Compare

July 19, 2022 15:50

graingert commented Jul 19, 2022

Copy link

Copy Markdown

Contributor Author

It's best to review this in side-by-side mode, because GenericWatcherTests needed to be indented: https://github.com/python/cpython/pull/95009/files?diff=split

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

graingert marked this pull request as ready for review

July 19, 2022 15:52

graingert requested review from 1st1 and asvetlov as code owners

July 19, 2022 15:52

graingert mentioned this pull request

Jul 19, 2022

gh-94182: run the PidfdChildWatcher on the running loop #94184

Merged

AlexWaygood added the skip news label

Jul 19, 2022

serhiy-storchaka approved these changes

Jul 21, 2022

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

graingert reacted with heart emoji

All reactions

❤️ 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Jul 21, 2022

graingert commented Jul 21, 2022

Copy link

Copy Markdown

Contributor Author

This should probably be backported to 3.10 as it's needed to verify a bugfix

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Jul 21, 2022

serhiy-storchaka merged commit 834bd5d into python:main

Jul 21, 2022

miss-islington commented Jul 21, 2022

Copy link

Copy Markdown

Contributor

Thanks @graingert for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jul 21, 2022

bedevere-bot commented Jul 21, 2022

Copy link

Copy Markdown

GH-95092 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed needs backport to 3.11

only security fixes

needs backport to 3.10 labels

Jul 21, 2022

bedevere-bot commented Jul 21, 2022

Copy link

Copy Markdown

GH-95093 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 21, 2022


          pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…

3b4ee85

…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 21, 2022


          pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…

0bf111e

…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <[email protected]>

graingert deleted the fix-generic-watcher-tests branch

July 21, 2022 11:57

miss-islington added a commit that referenced this pull request

Jul 21, 2022


          gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…

d19b5d8

…s_with_inactive_watcher (GH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <[email protected]>

graingert mentioned this pull request

Jul 21, 2022

[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail… #95099

Closed

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

graingert commented Jul 19, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graingert commented Jul 19, 2022

Uh oh!

graingert commented Jul 19, 2022

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

graingert commented Jul 21, 2022

Uh oh!

miss-islington commented Jul 21, 2022

Uh oh!

bedevere-bot commented Jul 21, 2022

Uh oh!

bedevere-bot commented Jul 21, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

graingert commented Jul 19, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.