GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93370: Don't print deprecated pysqlite version in test_sqlite3 by erlend-aasland · Pull Request #95017 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes gh-93370

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-93370: Don't print deprecated pysqlite version in test_sqlite3
9399f8c
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 19, 2022 18:13
@bedevere-bot bedevere-bot added the awaiting core review label Jul 19, 2022
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes labels Jul 19, 2022
@erlend-aasland

erlend-aasland commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

I consider it ok to merge this pretty quick. Will merge later tonight.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit be09bae into python:main Jul 19, 2022
@miss-islington

miss-islington commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 19, 2022
@erlend-aasland
erlend-aasland deleted the last-gh-93370-fix branch July 19, 2022 21:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2022
@erlend-aasland @miss-islington
pythongh-93370: Don't print deprecated pysqlite version in test_sqlit…
dc100d4 
…e3 (pythonGH-95017)

(cherry picked from commit be09bae)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 19, 2022

Copy link
Copy Markdown

GH-95024 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 19, 2022
@erlend-aasland

erlend-aasland commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

Oops, this should not be backported; I'll close the backport PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate sqlite3.version and sqlite3.version_info

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.