GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93939: Use new MODULE_name_STATE in wasm_assets script (GH-95035) by tiran · Pull Request #95035 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

wasm_assets.py was using the old MODULE_name variable to detect
if a shared extension is available. Emscripten browser builds now
correctly detect that e.g. json module is available.

  • Issue: Build shared extensions without distutils #93939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-93939: Use new MODULE_name_STATE in wasm_assets script
346999e 
``wasm_assets.py`` was using the old ``MODULE_name`` variable to detect
if a shared extension is available. Emscripten browser builds now
correctly detect that e.g. ``json`` module is available.
@tiran tiran added the needs backport to 3.11 only security fixes label Jul 20, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jul 20, 2022
@tiran tiran added the skip news label Jul 20, 2022
@tiran tiran changed the title gh-93939: Use new MODULE_name_STATE in wasm_assets script gh-93939: Use new MODULE_name_STATE in wasm_assets script (GH-95035) Jul 20, 2022
@tiran
tiran merged commit 0f34c7e into python:main Jul 20, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 20, 2022
@miss-islington

miss-islington commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran deleted the gh-93939-wasm-assets branch July 20, 2022 06:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2022
@tiran @miss-islington
pythongh-93939: Use new MODULE_name_STATE in wasm_assets script (pyth…
53e5198 
…onGH-95035)

(cherry picked from commit 0f34c7e)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 20, 2022

Copy link
Copy Markdown

GH-95039 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 20, 2022
miss-islington added a commit that referenced this pull request Jul 20, 2022
@miss-islington @tiran
gh-93939: Use new MODULE_name_STATE in wasm_assets script (GH-95035)
e98728a 
(cherry picked from commit 0f34c7e)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.