GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94998: Remove redundant condition in test_sqlite3/__main__.py by erlend-aasland · Pull Request #95052 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make 3.10 sqlite3 tests run #94998

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-94998: Remove redundant condition in test_sqlite3/__main__.py
60859df
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 20, 2022 15:39
@bedevere-bot bedevere-bot added the awaiting core review label Jul 20, 2022
@erlend-aasland erlend-aasland added skip news needs backport to 3.11 only security fixes labels Jul 20, 2022
@erlend-aasland
erlend-aasland merged commit 9d09e7b into python:main Jul 20, 2022
@miss-islington

miss-islington commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 20, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-remove-redundant-condition branch July 20, 2022 16:07
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2022
@erlend-aasland @miss-islington
pythongh-94998: Remove redundant condition in test_sqlite3/__main__.py (
73b5a9e 
pythonGH-95052)

(cherry picked from commit 9d09e7b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 20, 2022

Copy link
Copy Markdown

GH-95056 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 20, 2022
miss-islington added a commit that referenced this pull request Jul 20, 2022
@miss-islington @erlend-aasland
gh-94998: Remove redundant condition in test_sqlite3/__main__.py (GH-…
2ac1096 
…95052)

(cherry picked from commit 9d09e7b)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.