GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory (GH-95146) by erlend-aasland · Pull Request #95158 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 23, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR partially reverts gh-24421 (PR) and fixes the remaining concerns
given in gh-93044 (issue):

  • keyword arguments are passed as positional arguments to factory()
  • if an argument is not passed to sqlite3.connect(), its default value
    is passed to factory()

Co-authored-by: Serhiy Storchaka [email protected].
(cherry picked from commit a3d4d15)

Co-authored-by: Erlend Egeberg Aasland [email protected]

  • Issue: Python3.11: sqlite3.connect passes more arguments to factory() #95132

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend Egeberg Aasland @erlend-aasland
[3.11] pythongh-95132: Correctly relay *args and **kwds from sqlite3.…
dbee099 
…connect to factory (pythonGH-95146)

This PR partially reverts pythongh-24421 (PR) and fixes the remaining concerns
given in pythongh-93044 (issue):

- keyword arguments are passed as positional arguments to factory()
- if an argument is not passed to sqlite3.connect(), its default value
  is passed to factory()

Co-authored-by: Serhiy Storchaka <[email protected]>.
(cherry picked from commit a3d4d15)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 23, 2022 07:55
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2022
gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory #95146
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Jul 23, 2022
@erlend-aasland

erlend-aasland commented Jul 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

BTW, we should teach the cherry-picker to rerun clinic with -f.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 23, 2022
Python3.11: sqlite3.connect passes more arguments to factory() #95132
Closed
Unintentional changes in sqlite3.connect() #93044
Closed
@erlend-aasland
erlend-aasland merged commit 5d3f2fb into python:3.11 Jul 23, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 23, 2022
@erlend-aasland
erlend-aasland deleted the backport-a3d4d15-3.11 branch July 23, 2022 08:32
@AlexWaygood AlexWaygood mentioned this pull request Nov 2, 2022
Regression in help(sqlite3) between Python 3.10.8 and Python 3.11.0 #99003
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.