Description

serhiy-storchaka

opened on May 21, 2022

Issue body actions

There are some unintentional consequences of converting sqlite3.connect() to Argument Clinic in #40956.

1. The database argument always converted to bytes.
2. Keyword arguments are passed as positional arguments to factory().
3. If an argument is not passed to sqlite3.connect(), its default value is passed to factory().

It all works with the default factory=Connection, but factory can be an arbitrary callable, not completely compatible with Connection(). There may be a user code which uses a factory which only works with string database and does not support the uri argument. It worked fine in older versions when it is called with correct arguments, bet will become failing in 3.11.

This is a hypothetical scenario, but we should at least add a note about potential incompatibility. And I think that it is better to get rid of PyUnicode_FSConverter here.

Activity

1. serhiy-storchaka

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   3.11only security fixesonly security fixes

   topic-sqlite3

   on May 21, 2022
2. serhiy-storchaka

   added a commit that references this issue on May 21, 2022

   pythongh-93044: No longer convert the database argument of sqlite3.co…

   19c77f5
3. serhiy-storchaka

   linked a pull request that will close this issuegh-93044: No longer convert the database argument of sqlite3.connect() to bytes #93046on May 21, 2022
4. erlend-aasland commented on May 21, 2022

   

   erlend-aasland

   on May 21, 2022

   Contributor

   More actions

   FTR, sqlite3 was converted to Argument Clinic in gh-85128 (bpo-40956).
5. erlend-aasland commented on May 21, 2022

   

   erlend-aasland

   on May 21, 2022

   Contributor

   More actions

   Sounds good to me.
6. serhiy-storchaka

   closed this as completedin #93046on May 21, 2022
7. serhiy-storchaka

   added a commit that references this issue on May 21, 2022

   gh-93044: No longer convert the database argument of sqlite3.connect(…

   14c0d33
8. serhiy-storchaka

   reopened this on May 21, 2022
9. serhiy-storchaka

   added 2 commits that reference this issue on May 21, 2022

   [3.11] pythongh-93044: No longer convert the database argument of sql…

   2caba36

   [3.11] gh-93044: No longer convert the database argument of sqlite3.c…

   d9a48d2
10. erlend-aasland commented on May 21, 2022

    

    erlend-aasland

    on May 21, 2022

    Contributor

    More actions

    1. The database argument always converted to bytes.

    This concern was resolved with:

    • main: gh-93044: No longer convert the database argument of sqlite3.connect() to bytes #93046
    • 3.11: [3.11] gh-93044: No longer convert the database argument of sqlite3.c… #93048

    The remaining concerns were resolved with:

    • main: gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory #95146
    • 3.11: [3.11] gh-95132: Correctly relay *args and **kwds from sqlite3.connect to factory (GH-95146) #95158
11. erlend-aasland

    closed this as completedon May 21, 2022
12. erlend-aasland

    added 3 commits that reference this issue on Jul 23, 2022

    gh-95132: Correctly relay *args and **kwds from sqlite3.connect to fa…

    a3d4d15

    [3.11] pythongh-95132: Correctly relay *args and **kwds from sqlite3.…

    dbee099

    [3.11] gh-95132: Correctly relay *args and **kwds from sqlite3.connec…

    5d3f2fb

Issue actions