GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95235: Document undocumented parameters in sqlite3 functions and methods by erlend-aasland · Pull Request #95236 · python/cpython

Conversation

erlend-aasland commented Jul 25, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Document all parameters of all sqlite3 functions/methods #95235

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-95235: Document undocumented parameters in sqlite3 functions…

bbe34c5

… and methods

erlend-aasland requested a review from berkerpeksag as a code owner

July 25, 2022 10:14

erlend-aasland requested a review from CAM-Gerlach

July 25, 2022 10:14

bedevere-bot added docs

Documentation in the Doc dir

skip news awaiting core review labels

Jul 25, 2022

erlend-aasland added 2 commits

July 25, 2022 12:16


          Improve set_trace_callback

d7b4509


          callback => callable

2b3869d

erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Jul 25, 2022

CAM-Gerlach reviewed

Jul 25, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a couple minor comments/suggestions, thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland and others added 3 commits

July 25, 2022 17:23


          Update Doc/library/sqlite3.rst

97afd0f

Co-authored-by: CAM Gerlach <[email protected]>


          Update Doc/library/sqlite3.rst

92007db

Co-authored-by: CAM Gerlach <[email protected]>


          Address review

856a0be

CAM-Gerlach approved these changes

Jul 25, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland commented Jul 25, 2022

Copy link

Copy Markdown

Contributor Author

Thanks for the review, CAM!

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit ac6a94c into python:main

Jul 25, 2022

miss-islington commented Jul 25, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Jul 25, 2022

erlend-aasland deleted the sqlite-doc-params branch

July 25, 2022 16:46

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 25, 2022

bedevere-bot commented Jul 25, 2022

Copy link

Copy Markdown

GH-95249 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Jul 25, 2022

Copy link

Copy Markdown

GH-95250 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Jul 25, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 25, 2022


          pythongh-95235: Document undocumented parameters in sqlite3 functions…

04ce3fb

… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 25, 2022


          pythongh-95235: Document undocumented parameters in sqlite3 functions…

1b7f459

… and methods (pythonGH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

miss-islington added a commit that referenced this pull request

Jul 25, 2022


          gh-95235: Document undocumented parameters in sqlite3 functions and m…

4c10dba

…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

miss-islington added a commit that referenced this pull request

Jul 25, 2022


          gh-95235: Document undocumented parameters in sqlite3 functions and m…

0418d9f

…ethods (GH-95236)

Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit ac6a94c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland mentioned this pull request

Jul 26, 2022

Document all parameters of all sqlite3 functions/methods #95235

Closed

Reviewers

CAM-Gerlach

CAM-Gerlach approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jul 25, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Jul 25, 2022

Uh oh!

miss-islington commented Jul 25, 2022

Uh oh!

bedevere-bot commented Jul 25, 2022

Uh oh!

bedevere-bot commented Jul 25, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Jul 25, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.