GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95273: Normalise sqlite3 reference wording by erlend-aasland · Pull Request #95274 · python/cpython

Conversation

erlend-aasland commented Jul 26, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Improve the sqlite3 reference #95273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-95273: Normalise sqlite3 reference wording

4130c33

erlend-aasland requested a review from berkerpeksag as a code owner

July 26, 2022 11:23

erlend-aasland requested review from AlexWaygood and CAM-Gerlach

July 26, 2022 11:23

bedevere-bot added awaiting core review docs

Documentation in the Doc dir

skip news labels

Jul 26, 2022

erlend-aasland added 3 commits

July 26, 2022 13:24


          Syntax

ba083e8


          More syntax

413c54e


          Even more syntax

8eb1c20

erlend-aasland commented

Jul 26, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Guess what, even more syntax

d446d74

erlend-aasland commented

Jul 26, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Jul 26, 2022

CAM-Gerlach reviewed

Jul 27, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 3 commits

July 27, 2022 13:46


          Address CAM's review

5ac3e26


          syntax

cf109b0


          Address Alex' review

e92290a

AlexWaygood reviewed

Jul 27, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few small points

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with rocket emoji

All reactions

🚀 1 reaction

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address Alex's full review

fdc49d2

AlexWaygood reviewed

Jul 27, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Missed one spot

4cf5af4

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood approved these changes

Jul 27, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

erlend-aasland commented Jul 27, 2022

Copy link

Copy Markdown

Contributor Author

Great, thanks again, both of you!

AlexWaygood reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit 2361908 into python:main

Jul 27, 2022

miss-islington commented Jul 27, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Jul 27, 2022

erlend-aasland deleted the sqlite-reference/be-consistent branch

July 27, 2022 13:24

miss-islington commented Jul 27, 2022

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2361908a9d5553102f2b2294af44852a76d2ab03 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 27, 2022


          pythongh-95273: Normalise sqlite3 reference wording (pythonGH-95274)

540833f

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 27, 2022

bedevere-bot commented Jul 27, 2022

Copy link

Copy Markdown

GH-95329 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned erlend-aasland

Jul 27, 2022

bedevere-bot commented Jul 27, 2022

Copy link

Copy Markdown

GH-95330 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Jul 27, 2022

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request

Jul 27, 2022


          [3.10] pythongh-95273: Normalise sqlite3 reference wording (pythonGH-…

056afa8

…95274)

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland mentioned this pull request

Jul 27, 2022

Improve the sqlite3 reference #95273

Closed

5 tasks done

miss-islington added a commit that referenced this pull request

Jul 27, 2022


          gh-95273: Normalise sqlite3 reference wording (GH-95274)

e14c4d5

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland pushed a commit that referenced this pull request

Jul 27, 2022


          [3.10] gh-95273: Normalise sqlite3 reference wording (GH-95274) (#95330)

2ef7a72

Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>.
(cherry picked from commit 2361908)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland linked an issue

Aug 1, 2022

that may be closed by this pull request

Improve the sqlite3 reference #95273

Closed

5 tasks done

Reviewers

CAM-Gerlach

CAM-Gerlach left review comments

AlexWaygood

AlexWaygood approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jul 26, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Jul 27, 2022

Uh oh!

miss-islington commented Jul 27, 2022

Uh oh!

miss-islington commented Jul 27, 2022

Uh oh!

bedevere-bot commented Jul 27, 2022

Uh oh!

bedevere-bot commented Jul 27, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erlend-aasland commented Jul 26, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.