GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93678: Address stack exhaustion on WASI (GH-95296) by tiran · Pull Request #95296 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Commit 75c0c1b added function calls that increase stack consumption
slightly. This pushed recursion tests over the call stack limit of
wasmtime and broke three tests on wasm32-wasi.

Skip two tests and lower recursion limit of the third test.

  • Issue: Direct unit tests for compiler optimisations #93678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-93678: Address stack exhaustion on WASI
13a38ac 
Commit 75c0c1b added function calls that increase stack consumption
slightly. This pushed recursion tests over the call stack limit of
wasmtime and broke three tests on wasm32-wasi.

Skip two tests and lower recursion limit of the third test.
@tiran
tiran requested review from iritkatriel and sweeneyde July 26, 2022 19:31
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 26, 2022
@tiran

tiran commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

Failing build https://buildbot.python.org/all/#/builders/1046/builds/278
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran mentioned this pull request Jul 26, 2022
gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) #95288
Merged
@tiran tiran added the skip news label Jul 26, 2022
@iritkatriel

iritkatriel commented Jul 26, 2022

Copy link
Copy Markdown
Member

Are you sure you want to skip the tests? I’m hoping to get to the bottom of my change and reverse the impact.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

Are you sure you want to skip the tests? I’m hoping to get to the bottom of my change and reverse the impact.

Temporarily until you have developed a fix. The WASI buildbot is a stable tier 3 bot. The failing tests are showing up in unrelated PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Jul 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 26, 2022
@tiran tiran changed the title gh-93678: Address stack exhaustion on WASI gh-93678: Address stack exhaustion on WASI (GH-95296) Jul 26, 2022
@tiran
tiran merged commit 51c56f8 into python:main Jul 26, 2022
@tiran
tiran deleted the gh-93678-wasi branch July 26, 2022 20:14
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2022
@tiran tiran mentioned this pull request Jul 26, 2022
Direct unit tests for compiler optimisations #93678
Closed
@iritkatriel iritkatriel mentioned this pull request Jul 27, 2022
test_compiler_recursion_limit fails on wasm32-wasi #95335
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@sweeneyde sweeneyde Awaiting requested review from sweeneyde

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.