GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) by tiran · Pull Request #95288 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-94801: Fix regression in configure's CPPFLAGS handling
15a5d94
@tiran tiran added build The build process and cross-build release-blocker needs backport to 3.11 only security fixes labels Jul 26, 2022
@tiran
tiran requested review from erlend-aasland and pablogsal July 26, 2022 16:20
@bedevere-bot bedevere-bot added the awaiting core review label Jul 26, 2022
erlend-aasland
erlend-aasland approved these changes Jul 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 26, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@bedevere-bot

bedevere-bot commented Jul 26, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 15a5d94 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
pablogsal
pablogsal approved these changes Jul 26, 2022
View reviewed changes
@tiran

tiran commented Jul 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Failing build https://buildbot.python.org/all/#/builders/1046/builds/278 is fixed by #95296
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title gh-94801: Fix regression in configure's CPPFLAGS handling gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288) Jul 26, 2022
@tiran
tiran merged commit 9af7f87 into python:main Jul 26, 2022
@miss-islington

miss-islington commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2022
@tiran
tiran deleted the gh-94801-fix-cppflags branch July 26, 2022 19:39
@miss-islington

miss-islington commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9af7f87d763ed6e1c5f56ae40d8242ab22866b33 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Jul 26, 2022
tiran added a commit to tiran/cpython that referenced this pull request Jul 26, 2022
@tiran
[3.11] pythongh-94801: Fix regression in configure's CPPFLAGS handling (
9526b00 
pythonGH-95288).

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 26, 2022

Copy link
Copy Markdown

GH-95297 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2022
ambv pushed a commit that referenced this pull request Jul 27, 2022
@tiran
[3.11] gh-94801: Fix regression in configure's CPPFLAGS handling (GH-…
c72c1d6 
…95288) (GH-95297)

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <[email protected]>
@zanieb zanieb mentioned this pull request Dec 30, 2024
gh-128354: Use LIBS consistently over LDFLAGS in library build checks #128359
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

build The build process and cross-build release-blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @bedevere-bot @miss-islington @pablogsal @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.