GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions by erlend-aasland · Pull Request #95523 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve the sqlite3 reference #95273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-95273: Clarify when the sqlite_* attributes are added to sql…
66e1dec 
…ite3 exceptions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 1, 2022 09:05
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 labels Aug 1, 2022
@erlend-aasland
erlend-aasland requested a review from AlexWaygood August 1, 2022 09:05
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Aug 1, 2022
@erlend-aasland erlend-aasland mentioned this pull request Aug 1, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
AlexWaygood
AlexWaygood approved these changes Aug 1, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy one to review!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction
@erlend-aasland

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

That was an easy one to review!

I remembered you said you were swamped with work at the moment, so I took the chance with a small PR :)
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 1e6b635 into python:main Aug 1, 2022
@miss-islington

miss-islington commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 1, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-reference/improve-exception-accuracy branch August 1, 2022 09:15
@miss-islington

miss-islington commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1e6b63542e4856436c5c12148a6608ef9d148b71 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 1, 2022
@miss-islington miss-islington assigned erlend-aasland Aug 1, 2022
@bedevere-bot

bedevere-bot commented Aug 1, 2022

Copy link
Copy Markdown

GH-95524 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@erlend-aasland @miss-islington
pythongh-95273: Clarify when sqlite_* attributes are added to sqlite3…
f947a2e 
… exceptions (pythonGH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks done
@erlend-aasland erlend-aasland removed the needs backport to 3.10 label Aug 1, 2022
@erlend-aasland

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

Removing 3.10 backport, as 3.10 does not have this feature.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Aug 1, 2022
@miss-islington @erlend-aasland
gh-95273: Clarify when sqlite_* attributes are added to sqlite3 excep…
ad2872f 
…tions (GH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.