GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-95273: Align sqlite3 const refs with the devguide by erlend-aasland · Pull Request #95525 · python/cpython Conversation
|
|
OTOH, adding |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As discussed in python/devguide#916 (comment), using ``...`` is preferable to :const:`!...`.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks, Ezio! I forgot to change the parameter list types1; I'll update those before merging. OTOH, I'm not sure about changing those; maybe best to leave those to the Footnotes
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
That's what I would do (and have done in my PRs doing this elsewhere) as its simpler, consistent with standard Sphinxdoc usage and the structure makes its semantics unambiguous without the need for additional formatting, particularly since the context is as a type, not a code literal. If we need to customize it, we could monkeypatch the directive or submit an upstream PR instead of manually doing every one. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I regexed the doc, built it and and spot-checked the preview, and this LGTM, thanks @erlend-aasland
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, you spelled out my thoughts about this, CAM :) Also, +1 to this:
Thanks for the review, both of you. Highly appreciated! I'll land this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @erlend-aasland, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-95616 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…endations (pythonGH-95525) (cherry picked from commit 4d02572) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
…ons (GH-95525) (cherry picked from commit 4d02572) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
… recommendations (pythonGH-95525). (cherry picked from commit 4d02572) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95618 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Probably less concisely than you would have, though 😆 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…mendations (GH-95525). (#95618) (cherry picked from commit 4d02572) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Improve the sqlite3 reference
There was an error while loading. Please reload this page.