GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95007: Remove the NoneType return converter from Argument Clinic Doc by noamcohen97 · Pull Request #95529 · python/cpython

Conversation

@noamcohen97

@noamcohen97 noamcohen97 commented Aug 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

NoneType return converter was removed in 74b5e4c while documentation did not change

  • Issue: Argument Clinic does not increase NoneType refcount when returning NoneType from a function with no parameters #95007

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 1, 2022
@noamcohen97
pythongh-95007: Remove the NoneType return converter from Argument Cl…
f94dd7c 
…inic Doc

NoneType return converter was removed in 74b5e4c
@noamcohen97
noamcohen97 force-pushed the clinic-doc branch from 54a578e to f94dd7c Compare August 1, 2022 11:07
@noamcohen97
noamcohen97 marked this pull request as ready for review August 1, 2022 11:13
@AlexWaygood
AlexWaygood requested review from erlend-aasland and serhiy-storchaka August 1, 2022 12:04
@AlexWaygood AlexWaygood added the topic-argument-clinic label Aug 1, 2022
erlend-aasland
erlend-aasland approved these changes Aug 1, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 1, 2022
@erlend-aasland
erlend-aasland merged commit 347c783 into python:main Aug 1, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 1, 2022
@erlend-aasland

erlend-aasland commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR, Noam!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Aug 1, 2022
Argument Clinic does not increase NoneType refcount when returning NoneType from a function with no parameters #95007
Closed
@noamcohen97
noamcohen97 deleted the clinic-doc branch October 8, 2022 05:51
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@noamcohen97
python/cpython#95007: Remove the NoneType return converter from Argum…
d6ff211 
…ent Clinic Doc (python/cpython#95529)

The converter was removed in python/cpython@74b5e4c
erlend-aasland pushed a commit to python/devguide that referenced this pull request Sep 26, 2023
@noamcohen97 @erlend-aasland
python/cpython#95007: Remove the NoneType return converter from Argum…
2f81c6b 
…ent Clinic Doc (python/cpython#95529)

The converter was removed in python/cpython@74b5e4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@noamcohen97 @erlend-aasland @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.