GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95273: Improve documented return values and exceptions raised for sqlite3 class methods by erlend-aasland · Pull Request #95530 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve the sqlite3 reference #95273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-95273: Improve return values and exceptions raised for sqlit…
f9dc7d6 
…e3 class methods
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 1, 2022 11:31
@erlend-aasland erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels Aug 1, 2022
@erlend-aasland
erlend-aasland requested a review from AlexWaygood August 1, 2022 11:31
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Aug 1, 2022
@erlend-aasland erlend-aasland mentioned this pull request Aug 1, 2022
Improve the sqlite3 reference #95273
Closed
5 tasks done
@erlend-aasland erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks done
@erlend-aasland erlend-aasland changed the title gh-95273: Improve return values and exceptions raised for sqlite3 class methods gh-95273: Improve documented return values and exceptions raised for sqlite3 class methods Aug 1, 2022
@erlend-aasland
Fix html links
ccc8469
ezio-melotti
ezio-melotti reviewed Aug 4, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti
Merge branch 'main' into sqlite-reference/return-and-except
c4abfce
@ezio-melotti

ezio-melotti commented Aug 4, 2022

Copy link
Copy Markdown
Member

(@erlend-aasland: I fixed a merge conflict, if you are going to make changes to your local branch remember to pull the merge before you create more commits.)
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review Ezio! I'm extending this PR to use parameter lists in a few more cases. I'll ping you again when I'm ready for a second review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address review, and expand PR to include more stuff
a5ff4e6
AlexWaygood
AlexWaygood approved these changes Aug 4, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The words look good, and I'm always in favour of more type hints in the docs (where they're useful)! I'll leave the ReST/Sphinx syntax to Ezio :D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 3 commits August 4, 2022 13:50
Erlend Egeberg Aasland @AlexWaygood
Revert unneeded reflow
c4ae7fa 
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland
Be tidy: Keep descriptions on separate lines
8f3c1d6
@erlend-aasland
Merge remote-tracking branch 'upstream/main' into sqlite-reference/re…
fd7f77c 
…turn-and-except
@erlend-aasland

erlend-aasland commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

FTR, I'm going to land this later today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti
ezio-melotti reviewed Aug 4, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Sync with main
e215fe6
@erlend-aasland
erlend-aasland merged commit 12d92c7 into python:main Aug 4, 2022
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 4, 2022
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 12d92c733cfc00ee630b30e4e0250da400c83395 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the sqlite-reference/return-and-except branch August 4, 2022 19:58
@miss-islington miss-islington assigned erlend-aasland Aug 4, 2022
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 12d92c733cfc00ee630b30e4e0250da400c83395 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes and removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Aug 4, 2022
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 12d92c733cfc00ee630b30e4e0250da400c83395 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 12d92c733cfc00ee630b30e4e0250da400c83395 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

GH-95673 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 4, 2022
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.11] pythongh-95273: Improve documented return values and exception…
f86a981 
…s raised for sqlite3 class methods (pythonGH-95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.10] pythongh-95273: Improve documented return values and exception…
1e6ceaf 
…s raised for sqlite3 class methods (pythonGH-95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Aug 4, 2022
@bedevere-bot

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

GH-95674 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added a commit that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.11] gh-95273: Improve documented return values and exceptions rais…
c9986be 
…ed for sqlite3 class methods (GH-95530) (#95673)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Aug 4, 2022
@erlend-aasland
[3.10] gh-95273: Improve documented return values and exceptions rais…
4a204c1 
…ed for sqlite3 class methods (GH-95530) (#95674)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>.
(cherry picked from commit 12d92c7)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@erlend-aasland @ezio-melotti
@AlexWaygood @iritkatriel
pythongh-95273: Improve documented return values and exceptions raise…
26026fe 
…d for sqlite3 class methods (python#95530)

Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @ezio-melotti @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.