GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95388: Deprecate creating immutable types with mutable bases by encukou · Pull Request #95533 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Deprecate creating immutable types with mutable bases #95388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-95388: Deprecate creating immutable types with mutable bases
c21b016
@encukou
encukou requested a review from markshannon as a code owner August 1, 2022 13:36
@bedevere-bot bedevere-bot added the awaiting core review label Aug 1, 2022
@encukou
Fix ReST syntax
07afe1b
erlend-aasland
erlend-aasland reviewed Aug 1, 2022
View reviewed changes
Comment thread Lib/test/test_capi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_capi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/heaptype.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Address review comments
a8edc3a
erlend-aasland
erlend-aasland approved these changes Aug 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 3, 2022
@encukou
encukou merged commit a613fed into python:main Aug 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2022
@encukou
encukou deleted the no-immut-from-mut branch August 4, 2022 14:13
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@encukou @iritkatriel
pythongh-95388: Deprecate creating immutable types with mutable bases (…
9a9d043 
…pythonGH-95533)
@sobolevn sobolevn mentioned this pull request May 30, 2024
Remove deprecated feature to create immutable types with mutable bases #119775
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.