GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90110: Update the C Analyzer Tool Whitelists by ericsnowcurrently · Pull Request #95628 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Tools/c-analyzer is out-of-date. #90110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Fix the whitelists.
86ca535
@bedevere-bot bedevere-bot added the awaiting core review label Aug 3, 2022
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 3, 2022
@corona10

corona10 commented Aug 4, 2022

Copy link
Copy Markdown
Member

Out of curiosity: How to verify the list?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

There are ways of getting the list of symbols (e.g. nm on linux), and a basic grep will also find most globals. Either could be used for comparison. In fact, I added c-analyzer.py data check early on with verification in mind. However, it wasn't a priority and I don't recall how far I got. I expect it doesn't work currently.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 60f54d9 into python:main Aug 4, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 4, 2022
@ericsnowcurrently
ericsnowcurrently deleted the fix-c-analyzer branch August 4, 2022 16:47
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@ericsnowcurrently @iritkatriel
pythongh-90110: Update the C Analyzer Tool Whitelists (pythongh-95628)
753a3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @corona10 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.