GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-88177: Revert the new asyncio.sslproto implementation by ambv · Pull Request #95663 · python/cpython

Conversation

@ambv

@ambv ambv commented Aug 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This reverts #31275 and #31597 for Python 3.11 which enters Release Candidate stage tomorrow while an unresolved issue is present in the new code.

See #95573 for details.

  • Issue: Borrow asyncio ssl implementation from uvloop #88177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ambv added 2 commits August 4, 2022 18:31
@ambv
Revert "bpo-44011: New asyncio ssl implementation (python#31275)"
07e6a8f
This reverts commit 13c10bf.
@ambv
Revert "bpo-44011: Document ssl_shutdown_timeout added by revisited a…
722e189
…syncio SSL implementation (pythonGH-31597)"

This reverts commit 41ddcd3.
@ambv
ambv requested review from 1st1 and asvetlov as code owners August 4, 2022 16:53
@bedevere-bot bedevere-bot added the awaiting core review label Aug 4, 2022
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@bedevere-bot

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 722e189 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@ambv

ambv commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

This PR will hopefully not be necessary. I did stress-test it with -j8 -F on my M1 Max and it looks solid:

== Tests result: INTERRUPTED ==
Test suite interrupted by signal SIGINT.

1696 tests OK.

Total duration: 4 hour 42 min
Tests result: INTERRUPTED

________________________________________________________
Executed in  282.18 mins    fish           external
   usr time  1180.99 mins   43.00 micros  1180.99 mins
   sys time   34.76 mins  366.00 micros   34.76 mins
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv closed this Aug 5, 2022
@ambv
ambv deleted the revert-gh-31275 branch August 5, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.