GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95573: Reduce test data size in test_asyncio/test_ssl.py by fantix · Pull Request #95668 · python/cpython

Conversation

@fantix

@fantix fantix commented Aug 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The error was like:

Task exception was never retrieved
future: <Task finished name='Task-79' coro=<TestSSL.test_create_server_ssl_over_ssl.<locals>.handle_client() done, defined at cpython/Lib/test/test_asyncio/test_ssl.py:1039> exception=OSError(55, 'No buffer space available')>
Traceback (most recent call last):
  File "cpython/Lib/test/test_asyncio/test_ssl.py", line 1042, in handle_client
    data = await reader.readexactly(len(A_DATA))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "cpython/Lib/asyncio/streams.py", line 728, in readexactly
    await self._wait_for_data('readexactly')
  File "cpython/Lib/asyncio/streams.py", line 522, in _wait_for_data
    await self._waiter
  File "cpython/Lib/asyncio/selector_events.py", line 1049, in write
    n = self._sock.send(data)
        ^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 55] No buffer space available

It was suppressed because of this:

cpython/Lib/test/test_asyncio/test_ssl.py

Lines 1159 to 1160 in 8a0d9a6

with self._silence_eof_received_warning():
self.loop.run_until_complete(start_server())

  • Issue: test_asyncio: test_create_server_ssl_over_ssl() failed on ARM64 macOS 3.x #95573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fantix
pythongh-95573: Reduce test data size in test_asyncio/test_ssl.py
4284913
@fantix
fantix requested review from 1st1 and asvetlov as code owners August 4, 2022 19:02
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 4, 2022
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@bedevere-bot

bedevere-bot commented Aug 4, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4284913 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
ambv added 4 commits August 5, 2022 09:57
@ambv
Add Blurb
aad8a26
@ambv
Only decrease the buffer size on macOS
474cae5
@ambv
Merge branch 'main' into asyncio-test-ssl-size
7098c90
@ambv
Actually import sys
60ce74d
@ambv

ambv commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Note: all tests with buildbots pass here with 4284913. The red x is due to missing Misc/NEWS, which I fixed now. Additionally, as discussed on GH-95573, I made the smaller buffer only apply on macOS.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 3a9e1fd into python:main Aug 5, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Aug 5, 2022
@ambv ambv added the needs backport to 3.11 only security fixes label Aug 5, 2022
@miss-islington

miss-islington commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @fantix for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 5, 2022

Copy link
Copy Markdown

GH-95705 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
@fantix @miss-islington
pythongh-95573: Reduce test data size in test_asyncio/test_ssl.py (py…
1e3d3e5 
…thonGH-95668)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <[email protected]>
ambv pushed a commit that referenced this pull request Aug 5, 2022
@miss-islington @fantix
gh-95573: Reduce test data size in test_asyncio/test_ssl.py (GH-95668) (
954b887 
GH-95705)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <[email protected]>
@fantix
fantix deleted the asyncio-test-ssl-size branch August 8, 2022 18:36
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@fantix @ambv @iritkatriel
pythongh-95573: Reduce test data size in test_asyncio/test_ssl.py (py…
613b3fd 
…thonGH-95668)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@fantix @bedevere-bot @ambv @miss-islington @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.