GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95573: Fix a mistake in asyncio ssl test suppressing all logs by fantix · Pull Request #95687 · python/cpython

Conversation

@fantix

@fantix fantix commented Aug 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This was originally introduced here and inherited in the cpython test suite, preventing the root reason of issues like #95573 from being easily seen.

Basically the idea of this filter is to prevent a warning saying returning true from eof_received() has no effect when using ssl, so we need to check the message instead of the logger name (like logging.Filter does).

  • Issue: test_asyncio: test_create_server_ssl_over_ssl() failed on ARM64 macOS 3.x #95573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fantix
Fix a mistake in asyncio ssl test suppressing all logs
acdadb4
@fantix
fantix requested review from 1st1 and asvetlov as code owners August 4, 2022 22:35
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 4, 2022
@ambv ambv added needs backport to 3.11 only security fixes skip news needs backport to 3.10 and removed needs backport to 3.10 labels Aug 5, 2022
@ambv

ambv commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Actually this doesn't go to 3.10, test_ssl was only added in 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit e1d68b3 into python:main Aug 5, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Aug 5, 2022
@miss-islington

miss-islington commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @fantix for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 5, 2022

Copy link
Copy Markdown

GH-95699 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
@fantix @miss-islington
pythongh-95573: Fix a mistake in asyncio ssl tests suppressing all lo…
cf2c3a2 
…gs (pythonGH-95687)

(cherry picked from commit e1d68b3)

Co-authored-by: Fantix King <[email protected]>
ambv pushed a commit that referenced this pull request Aug 5, 2022
@miss-islington @fantix
gh-95573: Fix a mistake in asyncio ssl tests suppressing all logs (GH…
0e636e4 
…-95687) (GH-95699)

(cherry picked from commit e1d68b3)

Co-authored-by: Fantix King <[email protected]>
@fantix
fantix deleted the asyncio-test-fix-warning-suppress branch August 8, 2022 18:36
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@fantix @iritkatriel
pythongh-95573: Fix a mistake in asyncio ssl tests suppressing all lo…
04c1514 
…gs (python#95687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@fantix @ambv @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.