GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95691: Doc BufferedWriter and BufferedReader by 180909 · Pull Request #95703 · python/cpython

Conversation

@180909

@180909 180909 commented Aug 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

close: #95691

  • Issue: https://docs.python.org/3/library/io.html#class-hierarchy mis-orders the the BufferedIOBase subclasses explanation. #95691

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@180909
pythongh-95691: Doc BufferedWriter and BufferedReader
7b292e4
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 5, 2022
kumaraditya303
kumaraditya303 approved these changes Sep 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Sep 26, 2022
@kumaraditya303 kumaraditya303 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Sep 26, 2022
@kumaraditya303
kumaraditya303 requested a review from zware September 26, 2022 16:26
nanjekyejoannah
nanjekyejoannah approved these changes Oct 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 5, 2022
@nanjekyejoannah

nanjekyejoannah commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nanjekyejoannah
nanjekyejoannah merged commit 0d68879 into python:main Oct 5, 2022
@miss-islington

miss-islington commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @180909 for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels Oct 5, 2022
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97947 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 5, 2022
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97948 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@180909 @miss-islington
pythongh-95691: Doc BufferedWriter and BufferedReader (pythonGH-95703)
3bb6545
(cherry picked from commit 0d68879)

Co-authored-by: 180909 <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@180909 @miss-islington
pythongh-95691: Doc BufferedWriter and BufferedReader (pythonGH-95703)
4bfe632
(cherry picked from commit 0d68879)

Co-authored-by: 180909 <[email protected]>
nanjekyejoannah pushed a commit that referenced this pull request Oct 6, 2022
@miss-islington @180909
[3.11] gh-95691: Doc BufferedWriter and BufferedReader (GH-95703) (#9…
1144cf6
…7947)

gh-95691: Doc BufferedWriter and BufferedReader (GH-95703)
(cherry picked from commit 0d68879)

Co-authored-by: 180909 <[email protected]>

Co-authored-by: 180909 <[email protected]>
nanjekyejoannah pushed a commit that referenced this pull request Oct 6, 2022
@miss-islington @180909
[3.10] gh-95691: Doc BufferedWriter and BufferedReader (GH-95703) (#9…
e2591e4
…7948)

gh-95691: Doc BufferedWriter and BufferedReader (GH-95703)
(cherry picked from commit 0d68879)

Co-authored-by: 180909 <[email protected]>

Co-authored-by: 180909 <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
7938d6f
* main:
  pythonGH-88050: fix race in closing subprocess pipe in asyncio  (python#97951)
  pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
  pythongh-95986: Fix the example using match keyword (python#95989)
  pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)
  pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)
  pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)
  pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
  pythonGH-88968: Add notes about socket ownership transfers (python#97936)
  pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
1af2a98
* main: (53 commits)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
  pythonGH-88050: fix race in closing subprocess pipe in asyncio  (python#97951)
  pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962)
  pythongh-95986: Fix the example using match keyword (python#95989)
  pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944)
  pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929)
  pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610)
  pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
  pythonGH-88968: Add notes about socket ownership transfers (python#97936)
  pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@180909 @mpage
pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703)
97a27d8
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @180909 @pablogsal
[3.11] gh-95691: Doc BufferedWriter and BufferedReader (GH-95703) (#9…
508ef0f
…7947)

gh-95691: Doc BufferedWriter and BufferedReader (GH-95703)
(cherry picked from commit 0d68879)

Co-authored-by: 180909 <[email protected]>

Co-authored-by: 180909 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

https://docs.python.org/3/library/io.html#class-hierarchy mis-orders the the BufferedIOBase subclasses explanation.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@180909 @nanjekyejoannah @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.