GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95276: Add callable entry to the glossary by MonadChains · Pull Request #95738 · python/cpython

Conversation

MonadChains commented Aug 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This PR solves #95276

Issue: Add glossary / term for callable #95276

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


           pythongh-95276: Add callable entry to the glossary

04e411e

bedevere-bot added docs

Documentation in the Doc dir

skip news awaiting review labels

Aug 6, 2022

TeamSpen210 commented Aug 6, 2022

Copy link

Copy Markdown

I think it’d be better to not mention tp_call, and instead describe calling as the actual syntax func(arg). tp_call is specific to CPython, confusing to pure-Python programmers (the most likely readers of the glossary), and as of PEP 590 (Vectorcall) is not entirely the arbiter of how calling behaves. Other similar glossary entries don’t seem to mention type slots either.

MonadChains reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Aug 6, 2022

Copy link

Copy Markdown

Member

Thanks for the PR, @MonadChains!

I agree with @TeamSpen210 — this seems too technical and implementation-specific for a glossary entry. A good glossary entry is quite tricky: it needs to be short, informative, and useful to total beginners in Python programming.

erlend-aasland and MonadChains reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Aug 6, 2022

Copy link

Copy Markdown

Member

We need to describe "what a callable is" (the implications and meaning of something being "callable" at the Python level) rather than how it is implemented in CPython.

erlend-aasland and MonadChains reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          improve entry

c51fdc1

MonadChains commented Aug 6, 2022

Copy link

Copy Markdown

Contributor Author

Thanks @TeamSpen210 and @AlexWaygood. I modified the entry to remove the implementation details.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood self-requested a review

August 6, 2022 13:28

slateny reviewed

Sep 25, 2022

View reviewed changes

Comment thread

Doc/glossary.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Remove extra whitespaces

f57e6e6

kumaraditya303 requested a review from CAM-Gerlach

October 7, 2022 18:03

JelleZijlstra reviewed

Oct 7, 2022

View reviewed changes

Comment thread

Doc/glossary.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra self-assigned this

Oct 7, 2022


          Update glossary.rst

4e2bda3

JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Oct 12, 2022

JelleZijlstra merged commit e3bf125 into python:main

Oct 12, 2022

miss-islington commented Oct 12, 2022

Copy link

Copy Markdown

Contributor

Thanks @MonadChains for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting review label

Oct 12, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 12, 2022


          pythongh-95276: Add callable entry to the glossary (pythonGH-95738)

4f62baf

(cherry picked from commit e3bf125)

Co-authored-by: MonadChains <[email protected]>

bedevere-bot commented Oct 12, 2022

Copy link

Copy Markdown

GH-98202 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Oct 12, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 12, 2022


          pythongh-95276: Add callable entry to the glossary (pythonGH-95738)

82881e7

(cherry picked from commit e3bf125)

Co-authored-by: MonadChains <[email protected]>

bedevere-bot commented Oct 12, 2022

Copy link

Copy Markdown

GH-98203 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Oct 12, 2022

miss-islington added a commit that referenced this pull request

Oct 12, 2022


          gh-95276: Add callable entry to the glossary (GH-95738)

f94e6b4

(cherry picked from commit e3bf125)

Co-authored-by: MonadChains <[email protected]>

miss-islington added a commit that referenced this pull request

Oct 12, 2022


          gh-95276: Add callable entry to the glossary (GH-95738)

9e666bc

(cherry picked from commit e3bf125)

Co-authored-by: MonadChains <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Oct 14, 2022


          Merge branch 'main' into typewatch

6e53514

* main: (38 commits)
  pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)
  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)
  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)
  pythongh-98178: syslog() is not thread-safe on macOS (python#98213)
  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)
  pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)
  pythongh-96265: Formatting changes for faq/general (python#98129)
  tutorial: remove "with single quotes" (python#98204)
  pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)
  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)
  pythongh-97669: Fix test_tools reference leak (python#98216)
  pythongh-97669: Create Tools/patchcheck/ directory (python#98186)
  pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)
  Formatting fixes in contextlib docs (python#98111)
  pythongh-95276: Add callable entry to the glossary (python#95738)
  pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)
  Fix some incorrect indentation around the main switch (python#98177)
  pythongh-98172: Fix formatting in `except*` docs (python#98173)
  pythongh-97982: Remove asciilib_count() (python#98164)
  pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

Oct 14, 2022


          Merge branch 'main' into cached_property

0bb0c69

* main: (37 commits)
  pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)
  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)
  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)
  pythongh-98178: syslog() is not thread-safe on macOS (python#98213)
  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)
  pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)
  pythongh-96265: Formatting changes for faq/general (python#98129)
  tutorial: remove "with single quotes" (python#98204)
  pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)
  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)
  pythongh-97669: Fix test_tools reference leak (python#98216)
  pythongh-97669: Create Tools/patchcheck/ directory (python#98186)
  pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)
  Formatting fixes in contextlib docs (python#98111)
  pythongh-95276: Add callable entry to the glossary (python#95738)
  pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)
  Fix some incorrect indentation around the main switch (python#98177)
  pythongh-98172: Fix formatting in `except*` docs (python#98173)
  pythongh-97982: Remove asciilib_count() (python#98164)
  pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)
  ...

pablogsal pushed a commit that referenced this pull request

Oct 22, 2022


          gh-95276: Add callable entry to the glossary (GH-95738)

37d1659

(cherry picked from commit e3bf125)

Co-authored-by: MonadChains <[email protected]>

Reviewers

JelleZijlstra

JelleZijlstra left review comments

slateny

slateny left review comments

AlexWaygood

Awaiting requested review from AlexWaygood

CAM-Gerlach

Awaiting requested review from CAM-Gerlach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MonadChains commented Aug 6, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TeamSpen210 commented Aug 6, 2022

Uh oh!

AlexWaygood commented Aug 6, 2022

Uh oh!

AlexWaygood commented Aug 6, 2022

Uh oh!

MonadChains commented Aug 6, 2022

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Oct 12, 2022

Uh oh!

bedevere-bot commented Oct 12, 2022

Uh oh!

bedevere-bot commented Oct 12, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MonadChains commented Aug 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.