GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93274: Disable Limited API tests with Py_TRACE_REFS by encukou · Pull Request #95796 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This should fix the Py_TRACE_REFS buildbot.

(In the future we'll need a better way to write limited API tests.)

  • Issue: Receiving vector calls in the Py_LIMITED_API #93274

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Disable Limited API tests with Py_TRACE_REFS
430a940
@encukou encukou added the skip news label Aug 8, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Aug 8, 2022
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2022
@bedevere-bot

bedevere-bot commented Aug 8, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 430a940 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 8, 2022
@encukou encukou mentioned this pull request Aug 8, 2022
gh-93274: Expose receiving vectorcall in the Limited API #95717
Merged
vstinner
vstinner reviewed Aug 8, 2022
View reviewed changes
Comment thread Modules/_testcapi/vectorcall_limited.c
@@ -1,3 +1,16 @@
#include "pyconfig.h" // Py_TRACE_REFS

#ifdef Py_TRACE_REFS

@vstinner vstinner Aug 8, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move this #ifdef in _testcapimodule.c instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_testcapi/vectorcall_limited.c
// Py_TRACE_REFS is incompatible with Limited API
#include "parts.h"
int
_PyTestCapi_Init_VectorcallLimited(PyObject *m) {

@vstinner vstinner Aug 8, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest putting an #ifdef on the _PyTestCapi_Init_VectorcallLimited() call in _testcapimodole.c instead of defining a no-op function.

Maybe define somewhere a macro to decide if vectorcall is tested or not? Something like:

#ifndef Py_TRACE_REFS
#  define TEST_VECTORCALL
#endif

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

encukou commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

If the tests pass, I'll merge this as is and make it better later. I'd like to make testing limited API as smooth as possible, which'll be much easier without the pressure of a red buildbot.
I'll definitely take the comments into account!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit eb81c1a into python:main Aug 9, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 9, 2022
@encukou
encukou deleted the trace-refs-no-limited branch August 9, 2022 07:03
This was referenced Aug 9, 2022
Revert "gh-93274: Expose receiving vectorcall in the Limited API (GH-95717)" #95794
Closed
Receiving vector calls in the Py_LIMITED_API #93274
Closed
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@encukou @iritkatriel
Disable Limited API tests with Py_TRACE_REFS (pythonGH-95796)
727595b
@encukou

encukou commented Aug 15, 2022

Copy link
Copy Markdown
Member Author

@vstinner: #95991 includes your suggestions (with changes – the check is in parts.h rather than _testcapimodule.c, and the macro is LIMITED_API_AVAILABLE rather than TEST_VECTORCALL.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.