GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Add coverage for bytesarray_setitem by mdboom · Pull Request #95802 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Aug 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When both are provided, tp_ass_subscript takes precedence over tp_ass_item. Since bytesarray provides both, the existing test_setitem tests for bytesarray were not testing bytesarray_setitem, but bytesarray_ass_subscript. This is mostly fine, since Python code has to jump through some hoops to even call it, but a third-party library using PySequence_SetItem could potentially run into this uncovered case.

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
mdboom requested a review from brandtbucher August 8, 2022 19:45
@bedevere-bot bedevere-bot added the awaiting review label Aug 8, 2022
@mdboom mdboom added skip news needs backport to 3.11 only security fixes labels Aug 8, 2022
@mdboom mdboom mentioned this pull request Aug 8, 2022
Metabug: Improving C-level coverage #94808
Open
@mdboom mdboom added the tests Tests in the Lib/test dir label Aug 11, 2022
@mdboom mdboom closed this Aug 12, 2022
@mdboom mdboom reopened this Aug 12, 2022
@mdboom
mdboom force-pushed the coverage-bytesarray-setitem branch from 5f24775 to e717c5c Compare August 12, 2022 18:11
@mdboom
pythongh-94808: Add coverage for bytesarray_setitem
1c2a344
@mdboom
mdboom force-pushed the coverage-bytesarray-setitem branch from e717c5c to 1c2a344 Compare October 3, 2022 21:20
JelleZijlstra
JelleZijlstra approved these changes Oct 7, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any reason you didn't mark this for backporting to 3.10?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 7, 2022
@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
@mdboom

mdboom commented Oct 10, 2022

Copy link
Copy Markdown
Contributor Author

Looks good. Any reason you didn't mark this for backporting to 3.10?

No real reason not to -- for all these other coverage improvements linked to #94808, we've just been backporting to 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the needs backport to 3.10 label Oct 10, 2022
@JelleZijlstra
JelleZijlstra merged commit dfcdee4 into python:main Oct 10, 2022
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 10, 2022
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Sorry, @mdboom and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dfcdee4a18ece6f7c4fe1aa5830ee861f8b15b24 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 10, 2022

Copy link
Copy Markdown
Contributor

Sorry @mdboom and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dfcdee4a18ece6f7c4fe1aa5830ee861f8b15b24 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Oct 10, 2022

Copy link
Copy Markdown
Member

Thanks! I think it's good to backport new tests to the bugfix branches so we can be more confident in any future bugfixes. But testing on 3.11 is definitely more important.

Would you mind doing the manual backports? Feel free to skip 3.10 if you don't think it's worth it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@mdboom @mpage
pythongh-94808: Add coverage for bytesarray_setitem (python#95802)
fbfd13b
@mdboom
mdboom deleted the coverage-bytesarray-setitem branch December 22, 2022 15:50
@ZeroIntensity ZeroIntensity removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mdboom @miss-islington @JelleZijlstra @bedevere-bot @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.