GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95349: Hide a Distutils Warning Filter for test_check_c_globals by ericsnowcurrently · Pull Request #95837 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 9, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for gh-84236 (via gh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter.

  • Issue: warnings.filters was modified by test_check_c_globals #95349

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Hide a distutils warning filter during a test.
8628d9f
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 9, 2022
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 9, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 9, 2022
warnings.filters was modified by test_check_c_globals #95349
Closed
zooba
zooba approved these changes Aug 9, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 9, 2022
@zooba zooba added the needs backport to 3.11 only security fixes label Aug 9, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Aug 9, 2022
@miss-islington
miss-islington merged commit 3ff6d9a into python:main Aug 9, 2022
@miss-islington

miss-islington commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2022
@ericsnowcurrently @miss-islington
pythongh-95349: Hide a Distutils Warning Filter for test_check_c_glob…
eea836c 
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 9, 2022

Copy link
Copy Markdown

GH-95843 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 9, 2022
@ericsnowcurrently
ericsnowcurrently deleted the fix-95349-c-analyzer-distutils-warning branch August 9, 2022 23:05
ambv pushed a commit that referenced this pull request Aug 10, 2022
@miss-islington @ericsnowcurrently
gh-95349: Hide a Distutils Warning Filter for test_check_c_globals (G…
2c4bd21 
…H-95837) (GH-95843)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for gh-84236 (via gh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@zooba zooba added the needs backport to 3.10 label Aug 10, 2022
@miss-islington

miss-islington commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Aug 10, 2022

Copy link
Copy Markdown
Member

Sorry, this applies to 3.10 as well, so one more backport
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Aug 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2022
@ericsnowcurrently @miss-islington
pythongh-95349: Hide a Distutils Warning Filter for test_check_c_glob…
0d7ed30 
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 10, 2022

Copy link
Copy Markdown

GH-95864 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Aug 11, 2022
@miss-islington @ericsnowcurrently
gh-95349: Hide a Distutils Warning Filter for test_check_c_globals (G…
b11895e 
…H-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for gh-84236 (via gh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@ericsnowcurrently @iritkatriel
pythongh-95349: Hide a Distutils Warning Filter for test_check_c_glob…
9f5868c 
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @miss-islington @bedevere-bot @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.