GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95504: Fix negative numbers in PyUnicode_FromFormat by encukou · Pull Request #95848 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the non-refactoring part of #95505.

(Plus the ACKS fixup I forgot to include in #95819 😅)

  • Issue: Wrong sign placement in PyUnicode_FromFormat #95504

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@philg314 @encukou
Fix negative numbers in PyUnicode_FromFormat
d2099ed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 10, 2022
@encukou encukou mentioned this pull request Aug 10, 2022
gh-95504: Fix sign placement in PyUnicode_FromFormat #95505
Closed
philg314
philg314 approved these changes Aug 10, 2022
View reviewed changes

@philg314 philg314 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor adjustment to the news entries based on the news entries for the %% changes but other than that everything is in order. Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/C API/2022-07-31-21-58-27.gh-issue-95504.wy7B1F.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou and others added 2 commits August 10, 2022 11:04
@encukou @philg314
Apply What's New fixes
e7c617f 
Co-authored-by: philg314 <[email protected]>
@encukou
Remove trailing namespace in docs :/
bb48dfb
@encukou
encukou merged commit 71c3d64 into python:main Aug 10, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 10, 2022
@encukou
encukou deleted the unicode-from-format-negative branch August 10, 2022 11:12
philg314
philg314 reviewed Aug 10, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
copied as-is to the result string, and any extra arguments discarded.
(Contributed by Serhiy Storchaka in :gh:`95781`.)

* Fixed wrong sign placement in :c:func:`PyUnicode_FromFormat` and

@philg314 philg314 Aug 10, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Aug 10, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no problem! I'm just not a fan of the nitpycky tests :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 4, 2022
Wrong sign placement in PyUnicode_FromFormat #95504
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@philg314 philg314 philg314 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @philg314 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.