GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Split unicode tests from _testcapimodule.c & add some more by encukou · Pull Request #95819 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Move PyUnicode tests to a separate file
  • Add some more tests for PyUnicode_FromFormat

This is the refactoring & tests for existing functionality from #95505, leaving the change (and its tests) for another PR.

In addition to the changes in #95505, I made CHECK_FORMAT_* to check for SystemError when it gets NULL as the expected result. Some tests need that, as the behavior changed in #95784.

  • Issue: Split up _testcapimodule.c #93649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
philg314 and others added 6 commits August 9, 2022 13:34
@philg314 @encukou
Add tests for PyUnicode_FromFormat
8afdfb2
@encukou
Add Philip Georgi to ACKS
3618038
@philg314 @encukou
Add additional tests for PyUnicode_FromFormat
989d23e
@philg314 @encukou
pythongh-93649: Split unicode tests from _testcapimodule.c
0f6cd30
@philg314 @encukou
Use built-in AssertionError
6e69441
@encukou
Adjust test_string_from_format for current state
995e666
@encukou
encukou requested a review from a team as a code owner August 9, 2022 12:37
@bedevere-bot bedevere-bot added the awaiting core review label Aug 9, 2022
@encukou encukou added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 9, 2022
@bedevere-bot

bedevere-bot commented Aug 9, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 995e666 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 9, 2022
@encukou
encukou merged commit 325ae93 into python:main Aug 10, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 10, 2022
@encukou
encukou deleted the split-unicode-tests branch August 10, 2022 07:10
This was referenced Aug 10, 2022
gh-95504: Fix negative numbers in PyUnicode_FromFormat #95848
Merged
gh-95504: Fix sign placement in PyUnicode_FromFormat #95505
Closed
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@encukou @philg314 @iritkatriel
pythongh-93649: Split unicode tests from _testcapimodule.c & add some…
10d8903 
… more (pythonGH-95819)

- Move PyUnicode tests to a separate file
- Add some more tests for PyUnicode_FromFormat

Co-authored-by: philg314 <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Nov 14, 2022
Split up _testcapimodule.c #93649
Open
@encukou encukou mentioned this pull request Nov 22, 2022
Add missing step to C API tests instructions python/devguide#990
Merged
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 29, 2022
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Sorry, @encukou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 325ae93b6b7113cd4a4c2ce441615ae7def779e2 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned encukou Nov 29, 2022
@miss-islington

miss-islington commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Sorry @encukou, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 325ae93b6b7113cd4a4c2ce441615ae7def779e2 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 29, 2022

Copy link
Copy Markdown
Member

@encukou, could you please backport this PR to 3.11 and 3.10? It is necessary for backporting #99613, #99651, #99868, and others.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

I'd rather not -- _testcapi is only split up in 3.12. It would need backporting at least some of the other PRs in #93649.
I can rebase #99613 instead, would that help?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 29, 2022

Copy link
Copy Markdown
Member

Are you volunteering to backport also #99651, #99868 and future tests?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

I can put them on my TODO list.
The C changes are mostly about adding new functions, aren't they?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 30, 2022

Copy link
Copy Markdown
Member

I think that it would be less work to split _testcapi in 3.11 and 3.10, so I will try this way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@encukou @bedevere-bot @miss-islington @serhiy-storchaka @ZeroIntensity @philg314
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.