GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Improve coverage of _PyBytes_FormatEx by mdboom · Pull Request #95895 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Aug 11, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There were two specific areas not covered:

  • %(name) syntax
  • %*s syntax
  • Issue: Metabug: Improving C-level coverage #94808

Automerge-Triggered-By: GH:iritkatriel

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 11, 2022
@mdboom mdboom added needs backport to 3.11 only security fixes skip news labels Aug 11, 2022
@mdboom mdboom mentioned this pull request Aug 11, 2022
Metabug: Improving C-level coverage #94808
Open
@mdboom
pythongh-94808: Improve coverage of _PyBytes_FormatEx
d301fc3 
There were two specific areas not covered:

- %(name) syntax
- %*s syntax
@mdboom
mdboom force-pushed the coverage-bytesobject-PyBytes_FormatEx branch from d3efc12 to d301fc3 Compare August 11, 2022 17:38
@mdboom
mdboom requested a review from serhiy-storchaka August 22, 2022 13:36
iritkatriel
iritkatriel approved these changes Sep 7, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 7, 2022
@iritkatriel
Merge branch 'main' into coverage-bytesobject-PyBytes_FormatEx
abb0d55
@iritkatriel iritkatriel added the 🤖 automerge label Sep 7, 2022
@miss-islington

miss-islington commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit dde15f5 into python:main Sep 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 7, 2022
@miss-islington

miss-islington commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2022
@mdboom @miss-islington
pythongh-94808: Improve coverage of _PyBytes_FormatEx (pythonGH-95895)
c1964ac 
There were two specific areas not covered:

- %(name) syntax
- %*s syntax

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit dde15f5)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 7, 2022
@bedevere-bot

bedevere-bot commented Sep 7, 2022

Copy link
Copy Markdown

GH-96647 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Sep 7, 2022
@miss-islington @mdboom
gh-94808: Improve coverage of _PyBytes_FormatEx (GH-95895)
295f510 
There were two specific areas not covered:

- %(name) syntax
- %*s syntax

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit dde15f5)

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdboom @miss-islington @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.