GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-95841: IDLE - Revise Windows local doc url (GH-95845) by miss-islington · Pull Request #95905 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 11, 2022 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

GH-91242 replaced the Windows chm help file with a copy
of the html docs. This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy [email protected]
Approved by Steve Dower, #95845 (review), 2nd subblock.

  • Issue: IDLE - Fix help_url calculation on Windows. #95841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@terryjreedy @miss-islington
pythongh-95841: IDLE - Revise Windows local doc url (pythonGH-95845)
4093c82
pythonGH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner August 11, 2022 20:54
@bedevere-bot bedevere-bot mentioned this pull request Aug 11, 2022
gh-95841: IDLE - Revise Windows local doc url #95845
Merged
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error awaiting review labels Aug 11, 2022
terryjreedy
terryjreedy approved these changes Aug 11, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 11, 2022
@terryjreedy terryjreedy added the DO-NOT-MERGE label Aug 11, 2022
@miss-islington

miss-islington commented Aug 11, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy
terryjreedy merged commit 577dbc3 into python:3.11 Aug 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 12, 2022
@miss-islington
miss-islington deleted the backport-bdb2cf8-3.11 branch August 12, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.