GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95841: IDLE - Revise Windows local doc url by terryjreedy · Pull Request #95845 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Aug 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#91242 replaced the Windows chm help file with a copy
of the html docs. This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
It is based on Steve Dower's #91242 (comment).

Co-authored-by: Steve Dower

  • Issue: IDLE - Fix help_url calculation on Windows. #95841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-95841: IDLE - Revise Windows local doc url
eb11a46 
python#91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Aug 10, 2022
@terryjreedy terryjreedy self-assigned this Aug 10, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Aug 10, 2022
@terryjreedy
terryjreedy requested a review from zooba August 10, 2022 01:01
zooba
zooba reviewed Aug 10, 2022
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the Windows-only import, but maybe you know that's fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/idlelib/editor.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/idlelib/editor.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
Fix import, initialization.
b1ca323
@terryjreedy

terryjreedy commented Aug 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thank you for reviewing. After fixes, manual re-tests on repository 3.12 and installed 3.11 still pass.

A found hours ago, I found an August 2012 patch by Ned Deily updating the linux and macOS locations and changing the code a bit. I am saving that, with new updates, for 3.11.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit bdb2cf8 into python:main Aug 11, 2022
@miss-islington

miss-islington commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2022
@terryjreedy @miss-islington
pythongh-95841: IDLE - Revise Windows local doc url (pythonGH-95845)
4093c82 
pythonGH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 11, 2022

Copy link
Copy Markdown

GH-95905 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2022
@terryjreedy @miss-islington
pythongh-95841: IDLE - Revise Windows local doc url (pythonGH-95845)
d734492 
pythonGH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 11, 2022

Copy link
Copy Markdown

GH-95906 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Aug 11, 2022
@terryjreedy
terryjreedy deleted the winhelp branch August 11, 2022 20:56
@terryjreedy terryjreedy mentioned this pull request Aug 11, 2022
[3.11] gh-95841: IDLE - Revise Windows local doc url (GH-95845) #95905
Merged
miss-islington added a commit that referenced this pull request Aug 11, 2022
@miss-islington @terryjreedy
gh-95841: IDLE - Revise Windows local doc url (GH-95845)
bfaa071 
GH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
Co-authored-by: Steve Dower
(cherry picked from commit bdb2cf8)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy pushed a commit that referenced this pull request Aug 12, 2022
@miss-islington
gh-95841: IDLE - Revise Windows local doc url (GH-95845) (#95905)
577dbc3 
GH-91242 replaced the Windows chm help file with a copy
of the html docs.  This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.

Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Steve Dower
Approved by Steve Dower, #95845 (review), 2nd subblock.

(cherry picked from commit bdb2cf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@terryjreedy @miss-islington @bedevere-bot @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.