GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Coverage: __build_class__ inside a non-dict __builtins__ by mdboom · Pull Request #95932 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Aug 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds coverage for this case inside the LOAD_BUILD_CLASS opcode in

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
pythongh-94808: Coverage: __build_class__ inside a non-dict __builtins__
ec0c35e
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 12, 2022
@mdboom mdboom added the skip news label Aug 12, 2022
@mdboom mdboom mentioned this pull request Aug 12, 2022
Metabug: Improving C-level coverage #94808
Open
@mdboom mdboom added the needs backport to 3.11 only security fixes label Aug 12, 2022
brandtbucher
brandtbucher approved these changes Aug 15, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 15, 2022
@brandtbucher
brandtbucher merged commit 3adb4d8 into python:main Aug 15, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 15, 2022
@miss-islington

miss-islington commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2022
@mdboom @miss-islington
pythonGH-94808: Test __build_class__ inside non-dict __builtins__ (py…
0889e30 
…thonGH-95932)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 15, 2022
@bedevere-bot

bedevere-bot commented Aug 15, 2022

Copy link
Copy Markdown

GH-96004 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit that referenced this pull request Sep 8, 2022
@miss-islington @mdboom
GH-94808: Test __build_class__ inside non-dict __builtins__ (GH-95932) (
0c443c2 
#96004)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <[email protected]>

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdboom @miss-islington @bedevere-bot @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.