GeezerVison is showing github.com — gh-95914: Add Py_UNICODE encode APIs removed in PEP 624 to 3.11 What's New by CAM-Gerlach · Pull Request #96016 · python/cpython
Conversation
CAM-Gerlach
commented
Aug 16, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add a mention of the deprecated Py_UNICODE encode functions removed in Python 3.11 per PEP-624 by @methane in issue #88195 / PR #25881 to 3.11 What's New, as discussed in #95914 .
Inada-san, could you take a look at this?
Also, @AA-Turner @ezio-melotti @hugovk , any idea why ! appears to not be working as documented in :c:func: here, resulting in -n warnings and incorrect rendering? Does it have something to do with the legacy C role support still used by the CPython docs?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Also, @AA-Turner @ezio-melotti @hugovk , any idea why ! appears to not be working as documented in :c:func: here, resulting in -n warnings and incorrect rendering?
Nope... The ! prefix is meant to prevent creating a reference/hyperlink. But because the functions have been removed, you can omit the ! and it won't create a link anyway (and will render as code formatting).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach
commented
Aug 16, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The ! prefix is meant to prevent creating a reference/hyperlink.
Right, which is why I don't understand why it doesn't work, unless this is a Spihnx bug or some corner case (which I searched for at some length in the Sphinx repo and googled, to no avail). I figure if anyone knows, @AA-Turner would...
But because the functions have been removed, you can omit the ! and it won't create a link anyway (and will render as code formatting).
Right, of course, but the whole reason I'm adding the ! is because the functions have been removed, so Sphinx doesn't try to link them and fail with a ton of spurious warnings, obscuring real ones about actual bad references/object names amidst the noise. In that case, if for whatever reason ! doesn't work in the C domain, it would be IMO better to just use literals (as is generally used elsewhere) than known-broken references that generate a ton of spurious warnings.
|
ezio-melotti and hugovk reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I believe the markup for removed functions should be fixed before merging -- from :c:func:`...` to just ``...``.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach
commented
Aug 18, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I ended up going with the default-domain :func:`!...` for now, so at least the formatting is consistent and the semantics are close enough. However, I am still curious to know what's going on there...
This should be ready for final review now @pablogsal
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach reacted with hooray emoji
|
Thanks @CAM-Gerlach for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 18, 2022
… What's New (pythonGH-96016)
* 3.11 Whatsnew: Add Py_UNICODE encode functions removed in PEP 624
* Just use :func: instead of :c:func: for non-resolved funcs so ! works
(cherry picked from commit b6d88b7)
Co-authored-by: C.A.M. Gerlach <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
added a commit
that referenced
this pull request
Aug 19, 2022
…s New (GH-96016)
* 3.11 Whatsnew: Add Py_UNICODE encode functions removed in PEP 624
* Just use :func: instead of :c:func: for non-resolved funcs so ! works
(cherry picked from commit b6d88b7)
Co-authored-by: C.A.M. Gerlach <[email protected]>
Reviewers
methane
methane approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|