GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96017: Fix some compiler warnings (GH-96018) by tiran · Pull Request #96018 · python/cpython

Conversation

@tiran

@tiran tiran commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • "comparison of integers of different signs" in typeobject.c
  • only define static_builtin_index_is_set in DEBUG builds
  • only define recreate_gil with ifdef HAVE_FORK
  • Issue: Compiler warnings in main / 3.11 #96017

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-96017: Fix some compiler warnings
83a0cd0 
- "comparison of integers of different signs" in typeobject.c
- only define static_builtin_index_is_set in DEBUG builds
- unset NDEBUG before including assert.h
- only define recreate_gil with ifdef HAVE_FORK
@tiran
tiran requested a review from markshannon as a code owner August 16, 2022 06:49
@bedevere-bot bedevere-bot added the awaiting core review label Aug 16, 2022
@tiran tiran added needs backport to 3.11 only security fixes skip news and removed awaiting core review labels Aug 16, 2022
encukou
encukou reviewed Aug 16, 2022
View reviewed changes
Comment thread Modules/_testcapi/parts.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
tiran added 2 commits August 16, 2022 13:19
@tiran
Unpatch parts.h
2388df1
@tiran
Merge branch 'main' into pythongh-96017-compiler-warnings
928a2b9
@tiran tiran changed the title gh-96017: Fix some compiler warnings gh-96017: Fix some compiler warnings (GH-96018) Aug 19, 2022
@tiran
tiran merged commit d9c1b74 into python:main Aug 19, 2022
@miss-islington

miss-islington commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran deleted the gh-96017-compiler-warnings branch August 19, 2022 06:08
@miss-islington

miss-islington commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d9c1b746b5013f81d1724757bb3c6a1c87c4a8dc 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Aug 19, 2022
tiran added a commit to tiran/cpython that referenced this pull request Aug 19, 2022
@tiran
[3.11] pythongh-96017: Fix some compiler warnings (pythonGH-96018)
70dd200 
- "comparison of integers of different signs" in typeobject.c
- only define static_builtin_index_is_set in DEBUG builds
- only define recreate_gil with ifdef HAVE_FORK.
(cherry picked from commit d9c1b74)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 19, 2022

Copy link
Copy Markdown

GH-96106 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 19, 2022
ambv pushed a commit that referenced this pull request Oct 5, 2022
@tiran
[3.11] gh-96017: Fix some compiler warnings (GH-96018) (#96106)
eecbeec 
- only define recreate_gil with ifdef HAVE_FORK.
(cherry picked from commit d9c1b74)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @miss-islington @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.