GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: make the new internal classes pdb.ModuleTarget/ScriptTarget private by iritkatriel · Pull Request #96053 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 17, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
eb91e0b 
…Target private
@iritkatriel iritkatriel added skip news needs backport to 3.11 only security fixes labels Aug 17, 2022
@iritkatriel
iritkatriel requested review from jaraco and pablogsal August 17, 2022 17:35
@bedevere-bot bedevere-bot added the awaiting core review label Aug 17, 2022
jaraco
jaraco approved these changes Aug 18, 2022
View reviewed changes

@jaraco jaraco left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 18, 2022
@iritkatriel
Merge branch 'main' into pdb_private
1962ad3
@iritkatriel
iritkatriel merged commit 1a720c6 into python:main Aug 18, 2022
@miss-islington

miss-islington commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 18, 2022
@bedevere-bot

bedevere-bot commented Aug 18, 2022

Copy link
Copy Markdown

GH-96063 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2022
@iritkatriel @miss-islington
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
117c7c6 
…Target private (pythonGH-96053)

(cherry picked from commit 1a720c6)

Co-authored-by: Irit Katriel <[email protected]>
pablogsal pushed a commit that referenced this pull request Aug 18, 2022
@miss-islington @iritkatriel
[3.11] gh-95913: make the new internal classes pdb.ModuleTarget/Scrip…
1b9b485 
…tTarget private (GH-96053) (#96063)

Co-authored-by: Irit Katriel <[email protected]>
tiran pushed a commit to tiran/cpython that referenced this pull request Aug 19, 2022
@iritkatriel @tiran
pythongh-95913: make the new internal classes pdb.ModuleTarget/Script…
eae213f 
…Target private (pythonGH-96053)
@iritkatriel
iritkatriel deleted the pdb_private branch September 29, 2022 17:03
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 2, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @miss-islington @bedevere-bot @jaraco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.