GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90110: Get the C Analyzer Tool Working Again by ericsnowcurrently · Pull Request #96057 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 17, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We broke it with a recent _PyArg_Parser change.

Also:

  • moved the _PyArg_Parser whitelist entries over to ignored.tsv now that they are thread-safe
  • added some known globals from a currently-excluded file
  • dropped some outdated globals from the whitelist
  • Issue: Tools/c-analyzer is out-of-date. #90110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ericsnowcurrently added 7 commits August 15, 2022 14:08
@ericsnowcurrently
Update _parser.py.
bc00b8e
@ericsnowcurrently
Update the whitelists.
b534fd8
@ericsnowcurrently
Add a comment to MAX_SIZES.
e1c4f0b
@ericsnowcurrently
Set the max lines for the generated global objects.
8cc711d
@ericsnowcurrently
Ignore _PyArg_Parser globals.
3136535
@ericsnowcurrently
Add an empty "others" section.
bc7e0aa
@ericsnowcurrently
Clean up outdated globals from the whitelist.
19abfb6
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 17, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Aug 17, 2022
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review August 17, 2022 19:26
@ericsnowcurrently
ericsnowcurrently merged commit 5aac851 into python:main Aug 17, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 17, 2022
@ericsnowcurrently
ericsnowcurrently deleted the update-c-analyzer branch August 17, 2022 19:55
tiran pushed a commit to tiran/cpython that referenced this pull request Aug 19, 2022
@ericsnowcurrently @tiran
pythongh-90110: Get the C Analyzer Tool Working Again (pythongh-96057)
0c8b215
We broke it with a recent `_PyArg_Parser` change.

Also:
* moved the `_PyArg_Parser` whitelist entries over to ignored.tsv now that they are thread-safe
* added some known globals from a currently-excluded file
* dropped some outdated globals from the whitelist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.