GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-96073: Fix wild replacement in formatannotation by iyume · Pull Request #96074 · python/cpython

Conversation

iyume commented Aug 18, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Lib/inspect.py: Avoid wild replacement in formatannotation #96073

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythonGH-96073: Fix wild replacement in formatannotation

f14fcb4

bedevere-bot commented Aug 18, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting review label

Aug 18, 2022

sobolevn reviewed

Aug 29, 2022

View reviewed changes

sobolevn left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to add news and tests.

I also think that proposed solution can be simplified?

I propose adding a new module to test it, something like:

        new file:   Lib/test/typingdata/__init__.py
        new file:   Lib/test/typingdata/typing.py

In the future we can even more all ann_modules there 🤔

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

blurb-it Bot and others added 2 commits

August 29, 2022 12:35


          📜🤖 Added by blurb_it.

1f4b638


          Add test case

ba9ec59

iyume requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners

August 29, 2022 13:20

iyume commented Aug 29, 2022

Copy link

Copy Markdown

Contributor Author

@sobolevn I have added some test based on your suggestion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum removed their request for review

August 29, 2022 15:18

JelleZijlstra reviewed

Aug 31, 2022

View reviewed changes

Comment thread

Lib/inspect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Aug 31, 2022

View reviewed changes

Comment thread

Lib/test/typingdata/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Aug 31, 2022

View reviewed changes

Comment thread

Misc/NEWS.d/next/Library/2022-08-29-12-35-28.gh-issue-96073.WaGstf.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

iyume and others added 2 commits

August 31, 2022 14:44


          Update Misc/NEWS.d/next/Library/2022-08-29-12-35-28.gh-issue-96073.Wa…

a913982

…Gstf.rst

Co-authored-by: Jelle Zijlstra <[email protected]>


          using removeprefix and rename typingdata to typinganndata

9e1a9cc

iyume requested review from JelleZijlstra and removed request for Fidget-Spinner

August 31, 2022 07:14

sobolevn reviewed

Aug 31, 2022

View reviewed changes

Comment thread

Lib/test/typinganndata/inspect.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          rename inspect.py to ann_module9.py

ad19bf6

iyume requested review from sobolevn and removed request for JelleZijlstra

September 3, 2022 12:42

JelleZijlstra approved these changes

Oct 7, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Oct 7, 2022

JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Oct 7, 2022

JelleZijlstra merged commit d5fea01 into python:main

Oct 7, 2022

miss-islington commented Oct 7, 2022

Copy link

Copy Markdown

Contributor

Thanks @iyume for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Oct 7, 2022

bedevere-bot commented Oct 7, 2022

Copy link

Copy Markdown

GH-98045 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Oct 7, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 7, 2022


          pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…

ec569d1

…honGH-96074)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <[email protected]>

bedevere-bot removed the needs backport to 3.10 label

Oct 7, 2022

bedevere-bot commented Oct 7, 2022

Copy link

Copy Markdown

GH-98046 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 7, 2022


          pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…

d58c82e

…honGH-96074)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <[email protected]>

miss-islington added a commit that referenced this pull request

Oct 7, 2022


          GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)

107ba92

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <[email protected]>

miss-islington added a commit that referenced this pull request

Oct 7, 2022


          GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)

a3a3701

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <[email protected]>

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022


          pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…

41b8172

…hon#96074)

Co-authored-by: Jelle Zijlstra <[email protected]>

Reviewers

JelleZijlstra

JelleZijlstra approved these changes

sobolevn

Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

iyume commented Aug 18, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 18, 2022

Uh oh!

sobolevn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iyume commented Aug 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Oct 7, 2022

Uh oh!

bedevere-bot commented Oct 7, 2022

Uh oh!

bedevere-bot commented Oct 7, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iyume commented Aug 18, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

sobolevn left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.