GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-96075: move interned dict under runtime state by kumaraditya303 · Pull Request #96077 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Aug 18, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move interned dictionary to global runtime state #96075

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label Aug 18, 2022
@kumaraditya303 kumaraditya303 self-assigned this Aug 18, 2022
@kumaraditya303 kumaraditya303 added the skip news label Aug 18, 2022
@kumaraditya303
move interned dict under runtime state
415902a
@kumaraditya303
kumaraditya303 force-pushed the interned branch from f82d271 to 415902a Compare August 18, 2022 15:43
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently August 18, 2022 16:25
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 18, 2022
@bedevere-bot

bedevere-bot commented Aug 18, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 415902a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 18, 2022
ericsnowcurrently
ericsnowcurrently requested changes Aug 19, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_global_objects.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/unicodeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/unicodeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Aug 19, 2022
@bedevere-bot

bedevere-bot commented Aug 19, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Aug 19, 2022
kumaraditya303 added 3 commits August 20, 2022 17:18
@kumaraditya303
use static inline functions
53ac9e9
@kumaraditya303
whitespace
c6758d8
@kumaraditya303
Merge branch 'main' into interned
c161726
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently August 20, 2022 18:09
ericsnowcurrently
ericsnowcurrently approved these changes Aug 22, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Aug 22, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Aug 22, 2022
@miss-islington
miss-islington merged commit 129998b into python:main Aug 22, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 22, 2022
@kumaraditya303
kumaraditya303 deleted the interned branch August 23, 2022 10:02
@kumaraditya303 kumaraditya303 mentioned this pull request Aug 23, 2022
Move interned dictionary to global runtime state #96075
Closed
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@kumaraditya303 @mdboom
pythonGH-96075: move interned dict under runtime state (pythonGH-96077)
5484fa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @bedevere-bot @ericsnowcurrently @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.