GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96189: Fix test_invalid_utf8 on a number of build bots by mdboom · Pull Request #96190 · python/cpython

Conversation

@mdboom

@mdboom mdboom commented Aug 22, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559

  • Issue: test_invalid_utf8 test failing on some buildbots #96189

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
pythongh-96189: Fix test_invalid_utf8 on a number of build bots
cd9b0f5 
The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 22, 2022
@mdboom
mdboom requested a review from ericsnowcurrently August 22, 2022 21:52
@mdboom mdboom added skip news needs backport to 3.11 only security fixes labels Aug 22, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Aug 23, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 23, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Aug 23, 2022
@miss-islington
miss-islington merged commit 054328f into python:main Aug 23, 2022
@miss-islington

miss-islington commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels Aug 23, 2022
@bedevere-bot

bedevere-bot commented Aug 23, 2022

Copy link
Copy Markdown

GH-96218 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2022
@mdboom @miss-islington
pythongh-96189: Fix test_invalid_utf8 on a number of build bots (pyth…
3f2eace 
…onGH-96190)

The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.pyGH-L559
(cherry picked from commit 054328f)

Co-authored-by: Michael Droettboom <[email protected]>
pablogsal pushed a commit that referenced this pull request Aug 23, 2022
@miss-islington @mdboom
[3.11] gh-96189: Fix test_invalid_utf8 on a number of build bots (GH-…
c01fc9d 
…96190) (#96218)

Co-authored-by: Michael Droettboom <[email protected]>
mdboom added a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@mdboom
pythongh-96189: Fix test_invalid_utf8 on a number of build bots (pyth…
15814e1 
…onGH-96190)

The clearing of the temporary directory is not working on some platforms and
leaving behind files.

This has been updated to use the pattern in test_cmd_line.py [1] using the
special TESTFN rather than a test directory.

[1] https://github.com/python/cpython/blob/main/Lib/test/test_cmd_line.py#L559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdboom @miss-islington @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.