GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87092: use basicblock_last_instr consistently by iritkatriel · Pull Request #96243 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The compiler sometimes uses b->b_instr[b->b_iused-1] and sometimes basicblock_last_instr(b) for the same thing. This PR replaces the former by the latter, to simplify the code and make it more consistent.

  • Issue: Split compiler into code-gen, optimizer and assembler. #87092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-87092: use basicblock_last_instr consistently
5d4b484
@iritkatriel iritkatriel added the skip news label Aug 24, 2022
@iritkatriel
iritkatriel requested a review from brandtbucher August 24, 2022 14:51
@iritkatriel
iritkatriel requested a review from markshannon as a code owner August 24, 2022 14:51
@bedevere-bot bedevere-bot added the awaiting core review label Aug 24, 2022
@iritkatriel iritkatriel self-assigned this Aug 24, 2022
markshannon
markshannon approved these changes Aug 24, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 24, 2022
@iritkatriel
iritkatriel merged commit fba3b67 into python:main Aug 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 24, 2022
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@iritkatriel @mdboom
pythongh-87092: use basicblock_last_instr consistently in the compiler (
33c27a2 
pythonGH-96243)
@iritkatriel
iritkatriel deleted the basicblock_last_instr branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.