GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] gh-79217: Remove empty log line in the suspicious.py tool by gpshead · Pull Request #96498 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Sep 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.

backport cherry-pick of c3f52a5

this way backports with documentation errors can be diagnosed.

  • Issue: logger failure in suspicious.py #79217

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tirkarthi @gpshead
bpo-35036: Remove empty log line in the suspicious.py tool (pythonGH-…
8ec2a38 
…10024)

Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2022
@gpshead gpshead added docs Documentation in the Doc dir skip news and removed awaiting core review labels Sep 2, 2022
@gpshead gpshead assigned ned-deily Sep 2, 2022
@gpshead
gpshead marked this pull request as ready for review September 2, 2022 00:50
@gpshead
gpshead requested a review from ned-deily September 2, 2022 00:50
@gpshead gpshead added the type-bug An unexpected behavior, bug, or error label Sep 2, 2022
@gpshead

gpshead commented Sep 2, 2022

Copy link
Copy Markdown
Member Author

Probably not relevant to the 3.7 release itself given it's just in a tool related to checking the docs build. I needed this to fix a backporting docs issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily
ned-deily merged commit d5fe995 into python:3.7 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ned-deily ned-deily

Labels

docs Documentation in the Doc dir skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gpshead @ned-deily @bedevere-bot @tirkarthi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.