GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35036: Use empty message as default for logger by tirkarthi · Pull Request #10024 · python/cpython

Conversation

@tirkarthi

@tirkarthi tirkarthi commented Oct 21, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes the change introduced in ee171a2 where self.info() was replaced with self.logger.info() . self.info was deprecated but it had a default of message='' and the new change also follows the same. I think this is a no-op and can be removed but that is subjected to approval from the reviewer.

Original self.info definition :

def info(self, message='', nonl=False):
    # type: (unicode, bool) > None
    """Emit an informational message.

    If *nonl* is true, don't emit a newline at the end (which implies that
    more info output will follow soon.)

    .. deprecated:: 1.6
       Use :mod:`sphinx.util.logging` instead.
    """
    warnings.warn('app.info() is now deprecated. Use sphinx.util.logging instead.',
                  RemovedInSphinx20Warning)
    logger.info(message, nonl=nonl)

https://bugs.python.org/issue35036

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tirkarthi
Use empty message as default for logger
f0fd0de
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 21, 2018
@bedevere-bot bedevere-bot added the awaiting review label Oct 21, 2018
@tirkarthi tirkarthi mentioned this pull request Oct 21, 2018
bpo-34831: Asyncio tutorial #9748
Closed
@tirkarthi

tirkarthi commented Oct 21, 2018

Copy link
Copy Markdown
Member Author

cc @pablogsal for review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the skip news label Oct 21, 2018
pablogsal
pablogsal approved these changes Oct 21, 2018
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the PR!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 21, 2018
@pablogsal

pablogsal commented Oct 21, 2018

Copy link
Copy Markdown
Member

I have pushed to your branch removing the logline, as it is not doing anything and can be safely deleted.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Remove empty log line
ea7c4fb
@pablogsal
pablogsal force-pushed the bpo35036 branch from 1d15290 to ea7c4fb Compare October 21, 2018 12:44
@pablogsal
pablogsal merged commit c3f52a5 into python:master Oct 21, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 21, 2018
@tirkarthi

tirkarthi commented Oct 21, 2018

Copy link
Copy Markdown
Member Author

Sure, thanks for merging it :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi
tirkarthi deleted the bpo35036 branch October 22, 2018 06:33
@benjaminp benjaminp added the needs backport to 2.7 label Oct 8, 2019
@miss-islington

miss-islington commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Thanks @tirkarthi for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2019
@tirkarthi @miss-islington
bpo-35036: Remove empty log line in the suspicious.py tool (pythonGH-…
222ef50 
…10024)

Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.
(cherry picked from commit c3f52a5)

Co-authored-by: Xtreak <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Oct 8, 2019
@bedevere-bot

bedevere-bot commented Oct 8, 2019

Copy link
Copy Markdown

GH-16637 is a backport of this pull request to the 2.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Oct 8, 2019
@miss-islington @tirkarthi
bpo-35036: Remove empty log line in the suspicious.py tool (GH-10024)
e78d79c 
Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.
(cherry picked from commit c3f52a5)

Co-authored-by: Xtreak <[email protected]>
gpshead pushed a commit to gpshead/cpython that referenced this pull request Sep 2, 2022
@tirkarthi @gpshead
bpo-35036: Remove empty log line in the suspicious.py tool (pythonGH-…
8ec2a38 
…10024)

Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.
ned-deily pushed a commit that referenced this pull request Sep 2, 2022
@gpshead @tirkarthi
bpo-35036: Remove empty log line in the suspicious.py tool (GH-10024) (…
d5fe995 
…GH-96498)

Previous to commit ee171a2 the logline was working because of self.info() (now
deprecated) defaults to an empty message.

Co-authored-by: Xtreak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tirkarthi @pablogsal @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.