GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — changing limition to limitation by mehrdadmoradii · Pull Request #96542 · python/cpython

Conversation

@mehrdadmoradii

@mehrdadmoradii mehrdadmoradii commented Sep 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As mentioned in #96541 (comment), there is a small typo in the file.

  • Issue: Typo in: Standard Library > Integer string conversion length limitation > Affected APIs #96541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mehrdadmoradii
changing limition to limitation
a530cdc
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 3, 2022
@ghost

ghost commented Sep 3, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk added the skip issue label Sep 3, 2022
hugovk
hugovk approved these changes Sep 3, 2022
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Sep 3, 2022
@mehrdadmoradii

mehrdadmoradii commented Sep 3, 2022

Copy link
Copy Markdown
Contributor Author

Thanks!

Thank you for the review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303 kumaraditya303 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Sep 4, 2022
@kumaraditya303
kumaraditya303 requested a review from gpshead September 4, 2022 06:10
gpshead
gpshead approved these changes Sep 4, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 4, 2022
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 4, 2022
@gpshead
doc typo: limitation
a37041f
python#96542
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 4, 2022
@gpshead
doc typo: limitation
52f2c26
python#96542
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 4, 2022
@gpshead
doc typo: limitation
feaded8
python#96542
@gpshead
gpshead merged commit af6359d into python:main Sep 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 4, 2022
@miss-islington

miss-islington commented Sep 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @mehrdadmoradii for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 4, 2022
@bedevere-bot

bedevere-bot commented Sep 4, 2022

Copy link
Copy Markdown

GH-96551 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2022
@mehrdadmoradii @miss-islington
doc typo: spell limitation (pythonGH-96542)
6f84a02
(cherry picked from commit af6359d)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 4, 2022

Copy link
Copy Markdown

GH-96552 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Sep 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2022
@mehrdadmoradii @miss-islington
doc typo: spell limitation (pythonGH-96542)
4bba6f2
(cherry picked from commit af6359d)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
miss-islington added a commit that referenced this pull request Sep 4, 2022
@miss-islington @mehrdadmoradii
doc typo: spell limitation (GH-96542)
76d7105
(cherry picked from commit af6359d)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
miss-islington added a commit that referenced this pull request Sep 4, 2022
@miss-islington @mehrdadmoradii
doc typo: spell limitation (GH-96542)
c0af099
(cherry picked from commit af6359d)

Co-authored-by: Mehrdad Moradizadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mehrdadmoradii @miss-islington @bedevere-bot @gpshead @hugovk @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.