GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-72719: Remove deprecated `asyncore` and `asynchat` modules by sobolevn · Pull Request #96580 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Several notes:

  1. I followed the same path as smtpd in gh-93243: Make smtpd private before porting its users #93246 It was suggested in Remove asyncore, asynchat and smtpd modules #72719 (comment) by @vstinner
  2. I've added TODO items about completely removing these modules in the future

PEP: https://peps.python.org/pep-0594/

  • Issue: Remove asyncore, asynchat and smtpd modules #72719

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev and hugovk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@sobolevn
sobolevn requested review from a team and vsajip as code owners September 5, 2022 14:18
@bedevere-bot bedevere-bot added the awaiting review label Sep 5, 2022
sobolevn
sobolevn commented Sep 5, 2022
View reviewed changes
Comment thread .github/CODEOWNERS Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
sobolevn force-pushed the issue-72719 branch 2 times, most recently from 92a5bab to 97d7bc8 Compare September 5, 2022 14:29
@sobolevn
sobolevn requested a review from giampaolo September 5, 2022 14:31
theLastOfCats
theLastOfCats reviewed Sep 5, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
pythongh-72719: Remove deprecated asyncore and asynchat modules
99e3de9
@sobolevn
sobolevn force-pushed the issue-72719 branch from 113731a to 99e3de9 Compare September 5, 2022 14:55
@arhadthedev

arhadthedev commented Sep 25, 2022

Copy link
Copy Markdown
Member

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in asyncore but not in asyncio as soon as possible.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Sep 25, 2022

Copy link
Copy Markdown
Member Author

Ping @pablogsal as release manager 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Sep 25, 2022

Copy link
Copy Markdown
Member

Ping @pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@bedevere-bot

bedevere-bot commented Sep 25, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@arhadthedev arhadthedev mentioned this pull request Oct 3, 2022
tests still rely on the removed stdlib modules asyncore/asynchat #93243
Closed
2 of 12 tasks
@arhadthedev

arhadthedev commented Oct 6, 2022

Copy link
Copy Markdown
Member

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra
JelleZijlstra reviewed Oct 7, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn @JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU…
9a49615
…pzF3.rst

Co-authored-by: Jelle Zijlstra <[email protected]>
hugovk
hugovk reviewed Oct 28, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
4b7d32d
@hugovk hugovk mentioned this pull request Oct 28, 2022
Remove PCbuild/lib.pyproj #98817
Closed
@sobolevn sobolevn mentioned this pull request Oct 29, 2022
asyncore and asynchat will be removed in 3.12 python/typeshed#9033
Merged
vstinner
vstinner reviewed Nov 3, 2022
View reviewed changes
Comment thread Lib/test/support/asynchat.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/support/asyncore.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated
@@ -0,0 +1,3 @@
Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.

@vstinner vstinner Nov 3, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@sobolevn sobolevn Nov 5, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
Address review
968ef31
@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed
vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove last references:

  • Doc/library/socketserver.rst
  • Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner

vstinner commented Nov 7, 2022

Copy link
Copy Markdown
Member

When I removed the module last year (commit), I even renamed the asyncore module to test.support._asyncore. But I don't mind to call it test.support.asyncore.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@giampaolo

giampaolo commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Remove last mentions of modules
c50f6b7
@sobolevn
sobolevn requested a review from ezio-melotti as a code owner November 7, 2022 18:15
@sobolevn

sobolevn commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

Done, all three - removed!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/license.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

sobolevn added 2 commits November 8, 2022 14:56
@sobolevn
Merge main into issue-72719
c1b225b
@sobolevn
Restore license
ecd04df
vstinner
vstinner approved these changes Nov 8, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn reacted with hooray emoji sobolevn reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 8, 2022
@vstinner
vstinner merged commit e56e33d into python:main Nov 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 8, 2022
@vstinner

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member

Merged, thanks. Let's see how it goes with Python 3.12.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member

See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@opoplawski opoplawski mentioned this pull request Apr 1, 2023
[BR]: Fails to build with Python 3.12 - ModuleNotFoundError: No module named 'asynchat' fail2ban/fail2ban#3487
Closed
@arhadthedev arhadthedev mentioned this pull request May 25, 2023
gh-82082: Make our test suite pass on an IPv6-only Linux host #26225
Closed
@honglei honglei mentioned this pull request Jun 18, 2023
asyncore and asynchat may be removed from python 3.11 stdlib giampaolo/pyftpdlib#560
Closed
SreekanthModupalli

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@hugovk hugovk hugovk left review comments
@vstinner vstinner vstinner approved these changes
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@giampaolo giampaolo Awaiting requested review from giampaolo giampaolo is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
+2 more reviewers
@theLastOfCats theLastOfCats theLastOfCats left review comments
@SreekanthModupalli SreekanthModupalli SreekanthModupalli left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@sobolevn @arhadthedev @pablogsal @bedevere-bot @vstinner @giampaolo @JelleZijlstra @hugovk @theLastOfCats @SreekanthModupalli
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.