GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93963: Remove ResourceReaderDefaultsTests by jaraco · Pull Request #96598 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Sep 5, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Officially deprecate and remove abcs in importlib.abc moved to importlib.resources. #93963

Automerge-Triggered-By: GH:jaraco

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
bpo-93963: Remove ResourceReaderDefaultsTests. If these tests are imp…
30133e7 
…ortant, they should be implemented in importlib_resources.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 5, 2022
@jaraco jaraco added the needs backport to 3.11 only security fixes label Sep 5, 2022
@jaraco jaraco changed the title bpo-93963: Remove ResourceReaderDefaultsTests gh-93963: Remove ResourceReaderDefaultsTests Sep 5, 2022
@jaraco jaraco added the skip news label Sep 5, 2022
@jaraco
jaraco requested a review from iritkatriel September 5, 2022 19:01
@jaraco jaraco added the 🤖 automerge label Sep 5, 2022
@jaraco jaraco mentioned this pull request Sep 5, 2022
Officially deprecate and remove abcs in importlib.abc moved to importlib.resources. #93963
Closed
4 of 5 tasks
iritkatriel
iritkatriel approved these changes Sep 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 5, 2022
@miss-islington
miss-islington merged commit 52fe7e5 into python:main Sep 5, 2022
@miss-islington

miss-islington commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 5, 2022
@miss-islington

miss-islington commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Sorry, @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 52fe7e50c9945b7db60190b4b97e1213d05200b2 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington self-assigned this Sep 5, 2022
@bedevere-bot

bedevere-bot commented Sep 5, 2022

Copy link
Copy Markdown

GH-96602 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2022
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 5, 2022
@jaraco
[3.11] pythongh-93963: Remove ResourceReaderDefaultsTests (pythonGH-9…
04644c1 
…6598)

Automerge-Triggered-By: GH:jaraco.
(cherry picked from commit 52fe7e5)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco
jaraco deleted the bpo-93963/remove-resource-reader-defaults-tests branch September 5, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jaraco @miss-islington @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.