GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-96827: Don't touch closed loops from executor threads by gvanrossum · Pull Request #96837 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Sep 15, 2022

Copy link
Copy Markdown
Member

It's possible for an event loop's default executor to survive the loop. When the executor is finally shut down, a few things try to wake up the loop, and nasty RuntimeErrors are printed. But there's nothing the executor can do about that, so let's just not even try.

This is a draft PR because I haven't figured out a way to test this properly. (There's a repro in the issue, GH-96827.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum added 2 commits September 14, 2022 18:22
@gvanrossum
When chaining futures, skip callback if loop closed
9698862
@gvanrossum
When shutting down an executor, don't wake a closed loop
471792d
@bedevere-bot bedevere-bot added the awaiting core review label Sep 15, 2022
@gvanrossum gvanrossum added the topic-asyncio label Sep 15, 2022
@gvanrossum
Merge branch 'main' into asyncio-thread-late
d290359
@kumaraditya303
kumaraditya303 self-requested a review September 17, 2022 10:29
@gvanrossum
gvanrossum marked this pull request as ready for review September 29, 2022 22:06
@gvanrossum
gvanrossum requested review from 1st1 and asvetlov as code owners September 29, 2022 22:06
@gvanrossum

gvanrossum commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

At this point (after investing over an hour of my time) I feel it's not worth it to try and come up with a test that reproduces the original issue. The changes appear straightforward enough: in certain edge cases don't attempt to set a future's state when its loop is already closed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Sep 30, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303 kumaraditya303 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Sep 30, 2022
@blurb-it
📜🤖 Added by blurb_it.
a396ba6
@gvanrossum
gvanrossum merged commit e9d6376 into python:main Sep 30, 2022
@miss-islington

miss-islington commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 30, 2022
@gvanrossum
gvanrossum deleted the asyncio-thread-late branch September 30, 2022 19:55
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97690 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97691 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Sep 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@gvanrossum @miss-islington
pythonGH-96827: Don't touch closed loops from executor threads (pytho…
0473fe7 
…nGH-96837)

* When chaining futures, skip callback if loop closed.
* When shutting down an executor, don't wake a closed loop.
(cherry picked from commit e9d6376)

Co-authored-by: Guido van Rossum <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@gvanrossum @miss-islington
pythonGH-96827: Don't touch closed loops from executor threads (pytho…
05e0a9e 
…nGH-96837)

* When chaining futures, skip callback if loop closed.
* When shutting down an executor, don't wake a closed loop.
(cherry picked from commit e9d6376)

Co-authored-by: Guido van Rossum <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @gvanrossum
GH-96827: Don't touch closed loops from executor threads (GH-96837)
9560952 
* When chaining futures, skip callback if loop closed.
* When shutting down an executor, don't wake a closed loop.
(cherry picked from commit e9d6376)

Co-authored-by: Guido van Rossum <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @gvanrossum
GH-96827: Don't touch closed loops from executor threads (GH-96837)
a5c503f 
* When chaining futures, skip callback if loop closed.
* When shutting down an executor, don't wake a closed loop.
(cherry picked from commit e9d6376)

Co-authored-by: Guido van Rossum <[email protected]>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@gvanrossum @serhiy-storchaka
pythonGH-96827: Don't touch closed loops from executor threads (pytho…
c6203f8 
…n#96837)

* When chaining futures, skip callback if loop closed.
* When shutting down an executor, don't wake a closed loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gvanrossum @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.