GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-95778: Mention sys.set_int_max_str_digits() in error message (#96874) by vstinner · Pull Request #96877 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When ValueError is raised if an integer is larger than the limit, mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)

  • Issue: CVE-2020-10735: Prevent DoS by large int<->str conversions #95778

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-95778: Mention sys.set_int_max_str_digits() in error message (#96874)
5303abb 
When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)
@bedevere-bot bedevere-bot added the awaiting core review label Sep 16, 2022
@bedevere-bot bedevere-bot mentioned this pull request Sep 16, 2022
gh-95778: Mention sys.set_int_max_str_digits() in error message #96874
Merged
@vstinner

vstinner commented Sep 16, 2022

Copy link
Copy Markdown
Member Author

cc @gpshead
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead added needs backport to 3.7 labels Sep 16, 2022
gpshead
gpshead approved these changes Sep 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 16, 2022
@ned-deily
Merge branch '3.9' into maxdigits_msg39
d86ae1c
gpshead
gpshead approved these changes Sep 28, 2022
View reviewed changes
@ambv
ambv merged commit 4118813 into python:3.9 Oct 4, 2022
@miss-islington

miss-islington commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.8 labels Oct 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
@vstinner @miss-islington
[3.9] pythongh-95778: Mention sys.set_int_max_str_digits() in error m…
c21a2ec 
…essage (pythonGH-96874) (pythonGH-96877)

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)

Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit 4118813)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 4, 2022

Copy link
Copy Markdown

GH-97835 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 4, 2022

Copy link
Copy Markdown

GH-97836 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Oct 4, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
@vstinner @miss-islington
[3.9] pythongh-95778: Mention sys.set_int_max_str_digits() in error m…
d5d5f65 
…essage (pythonGH-96874) (pythonGH-96877)

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)

Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit 4118813)

Co-authored-by: Victor Stinner <[email protected]>
ambv pushed a commit that referenced this pull request Oct 4, 2022
@miss-islington @vstinner
[3.8] gh-95778: Mention sys.set_int_max_str_digits() in error message (…
dca2fd2 
…GH-96874) (GH-96877) (GH-97835)

[3.9] gh-95778: Mention sys.set_int_max_str_digits() in error message (GH-96874) (GH-96877)

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)

Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit 4118813)

Co-authored-by: Victor Stinner <[email protected]>
@ambv ambv mentioned this pull request Oct 4, 2022
[3.7] gh-95778: Mention sys.set_int_max_str_digits() in error message (GH-96874) (GH-96877) #97836
Merged
ambv pushed a commit that referenced this pull request Oct 4, 2022
@miss-islington @vstinner
[3.7] gh-95778: Mention sys.set_int_max_str_digits() in error message (…
7fcfa94 
…GH-96874) (GH-96877) (GH-97836)

[3.9] gh-95778: Mention sys.set_int_max_str_digits() in error message (GH-96874) (GH-96877)

When ValueError is raised if an integer is larger than the limit,
mention sys.set_int_max_str_digits() in the error message.

(cherry picked from commit e841ffc)

Co-authored-by: Ned Deily <[email protected]>
(cherry picked from commit 4118813)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner deleted the maxdigits_msg39 branch December 13, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @miss-islington @bedevere-bot @gpshead @ambv @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.